Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: arc direction #209

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

ldevillez
Copy link
Collaborator

Description

Pgf 2.0 does not handle well angle not in the range [-360, 360]. the angle of an arc will now be sanitize (with a new function) to put them in this range.

Before:
screenshot_20240828_075347

After:
screenshot_20240828_075259

Fixes #208

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Took a portion of the faulty svg and test that it renders correctly.
Added a new test

Checklist:

  • My code follows the style guidelines of this project (black/pylint)
  • I have updated the changelog with the corresponding changes
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ldevillez ldevillez linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1117 1109 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
svg2tikz/tikz_export.py 99% 🟢
tests/test_complete_files.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 8d1483a by action🐍

@ldevillez ldevillez merged commit 6687ad1 into master Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported arcs are often backwards
1 participant