Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: support for S letter command #211

Merged

Conversation

ldevillez
Copy link
Collaborator

Description

S command were not supported in SVG2tikz. Inkex seems to do all the work to compute the points for the S command as for a C command. S and C commands are using the same logic

Fixes #210

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on the svg of #210
New test using part of the logo included in the code

Checklist:

  • My code follows the style guidelines of this project (black/pylint)
  • I have updated the changelog with the corresponding changes
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ldevillez ldevillez linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 24, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1120 1112 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
svg2tikz/tikz_export.py 99% 🟢
tests/test_complete_files.py 99% 🟢
TOTAL 99% 🟢

updated for commit: 0040180 by action🐍

@ldevillez ldevillez merged commit 508329e into master Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something went totally wrong with curves in logo
1 participant