Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Moment dependency to date-fns #14

Closed
y0c opened this issue Mar 10, 2019 · 4 comments
Closed

Change Moment dependency to date-fns #14

y0c opened this issue Mar 10, 2019 · 4 comments
Assignees
@y0c
Labels
🚴‍♂️ in progress 🛠 refactoring
Milestone
v1.0.0

Comments

@y0c
Copy link
Owner

y0c commented Mar 10, 2019

Moment.js dependency will be change due to bundle size issue
@y0c y0c added this to the v0.3.6 milestone Mar 10, 2019
@y0c y0c self-assigned this Mar 10, 2019
@ghost
Copy link

ghost commented Mar 12, 2019

Day.Js is a nice alternative to me

⏰ Day.js 2KB immutable date library alternative to Moment.js with the same modern API

https://github.com/iamkun/dayjs

@y0c
Copy link
Owner Author

y0c commented Mar 12, 2019

Thank you for your cooment!
i will consider Day.js

@y0c y0c modified the milestones: v0.3.6, v1.0.0 Mar 18, 2019
@iamkun
Copy link

iamkun commented Mar 25, 2019

Just noticed this interesting topic from your PR iamkun/dayjs#543

Is there anything I can help with this dependency replacement?

And we can release all the changes in 1.8.12.

@y0c
Copy link
Owner Author

y0c commented Mar 25, 2019

Thanks to your help, it's going well.

y0c added a commit that referenced this issue Mar 28, 2019
@y0c
refactor: change moment dependency to day.js (#14)
a26d1a3
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
refactor: change default locale dayjs en (#14)
8b4c90b
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
refactor: remove moment dependency (#14)
f299b77
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
chore: remove moment dependency (#14)
801a5de
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
refactor: change locale moment to dayjs (#14)
debcb5f
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
chore: remove @types/moment (#14)
28ac879
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
fix: remove unused moment import (#14)
ae1e6d2
y0c added a commit that referenced this issue Mar 28, 2019
@y0c
doc: change moment.js guide to day.js (#14)
da1215d
@y0c y0c added the review label Mar 28, 2019
@y0c y0c closed this as completed in db1c8e5 Mar 28, 2019
@y0c y0c removed the review label Mar 28, 2019
@y0c y0c reopened this Mar 28, 2019
@y0c y0c closed this as completed Mar 28, 2019
y0c added a commit that referenced this issue Mar 31, 2019
@y0c
test: fix broken test (#14)
fc00900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y0c y0c

Labels
🚴‍♂️ in progress 🛠 refactoring
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@y0c @iamkun