Don't name the output of the const block #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaahc can you take a look at this? As noted in #46 (comment) recent nightly Rust versions are seeing a bunch of warnings from code generated by |
peddermaster2
approved these changes
May 5, 2024
|
@yaahc can we get some feedback on this issue? |
7 tasks
Manishearth
approved these changes
Jun 18, 2024
robertbastian
pushed a commit
to unicode-org/icu4x
that referenced
this pull request
Jun 19, 2024
The displaydoc warnings need yaahc/displaydoc#47, but I don't think they break non-clippy CI for us, and I'm working on getting that published.
Manishearth
approved these changes
Jun 20, 2024
Don't name the output of the const block in which traits are implemented. This doesn't play well with Rust RFC 3373, and isn't necessary for correctness. Fixes yaahc#46
Manishearth
force-pushed
the
anonymous-const
branch
from
ff2f562
to
c8d66ad
Compare
This was referenced Jun 20, 2024
robertbastian
pushed a commit
to unicode-org/icu4x
that referenced
this pull request
Jun 20, 2024
Should fix the nonlocal impl warnings on nightly/beta. Pulls in yaahc/displaydoc#47
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't name the output of the const block in which traits are implemented. This doesn't play well with Rust RFC 3373, and isn't necessary for correctness.
Fixes #46