From f37990610b7432d3d62e8b968998a68bcb6d9ed6 Mon Sep 17 00:00:00 2001 From: Kevin Hinterlong Date: Tue, 15 Aug 2017 09:51:45 -0500 Subject: [PATCH] Remove unused imports and add changelog --- CHANGELOG.md | 3 +++ .../application/AbstractDimensionValueProvider.java | 2 -- .../bard/webservice/application/DimensionValueLoader.java | 6 ------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db9340ecd4..a2cad3d35c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,9 @@ Current ### Changed: +- [DruidDimensionLoader is now a more generic DimensionValueLoader](https://github.com/yahoo/fili/pull/449) + * The `DimensionValueLoader` takes in a collection of `AbstractDimensionValueProvider`s to allow for non-Druid dimensions to be loaded. + - [Use all available segment metadata in fili-generic-example](https://github.com/yahoo/fili/pull/445) * The fili-generic-example now uses all segment metadata given by Druid instead of just the first one and also provides it to the metadata service. diff --git a/fili-core/src/main/java/com/yahoo/bard/webservice/application/AbstractDimensionValueProvider.java b/fili-core/src/main/java/com/yahoo/bard/webservice/application/AbstractDimensionValueProvider.java index a75e92134f..4315656898 100644 --- a/fili-core/src/main/java/com/yahoo/bard/webservice/application/AbstractDimensionValueProvider.java +++ b/fili-core/src/main/java/com/yahoo/bard/webservice/application/AbstractDimensionValueProvider.java @@ -17,8 +17,6 @@ import org.slf4j.LoggerFactory; import java.util.List; -import java.util.function.BiConsumer; -import java.util.function.Consumer; import java.util.stream.Collectors; /** diff --git a/fili-core/src/main/java/com/yahoo/bard/webservice/application/DimensionValueLoader.java b/fili-core/src/main/java/com/yahoo/bard/webservice/application/DimensionValueLoader.java index 4f60a2dac1..8c6255e48e 100644 --- a/fili-core/src/main/java/com/yahoo/bard/webservice/application/DimensionValueLoader.java +++ b/fili-core/src/main/java/com/yahoo/bard/webservice/application/DimensionValueLoader.java @@ -4,20 +4,14 @@ import com.yahoo.bard.webservice.config.SystemConfig; import com.yahoo.bard.webservice.config.SystemConfigProvider; -import com.yahoo.bard.webservice.data.dimension.Dimension; -import com.yahoo.bard.webservice.data.dimension.DimensionRow; import com.yahoo.bard.webservice.druid.client.FailureCallback; import com.yahoo.bard.webservice.druid.client.HttpErrorCallback; import org.joda.time.DateTime; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import java.util.Collection; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicReference; -import java.util.function.BiConsumer; -import java.util.function.Consumer; import javax.inject.Singleton;