Allow for stricter no-literals rule #1202
Conversation
lib/rules/jsx-no-literals.js
Outdated
| */ | ||
| 'use strict'; | ||
|
|
||
| // ------------------------------------------------------------------------------ | ||
| // Rule Definition | ||
| // ------------------------------------------------------------------------------ | ||
|
|
||
| var NO_STRINGS = 'no-strings'; |
| function getValidation(node) { | ||
| const standard = !/^[\s]+$/.test(node.value) && | ||
| node.parent && | ||
| node.parent.type.indexOf('JSX') !== -1 && |
There was a problem hiding this comment.
Will node.parent always have a type property that's a string or an array?
There was a problem hiding this comment.
This was the existing validation. I just removed part of it if you enable the option.
| {'Test'} | ||
| </Foo> | ||
| `, | ||
| parser: 'babel-eslint', |
There was a problem hiding this comment.
Please also add identical test cases that use the default parser.
lib/rules/jsx-no-literals.js
Outdated
| @@ -17,6 +20,8 @@ module.exports = { | |||
| }, | |||
|
|
|||
| schema: [{ | |||
| enum: [NO_STRINGS] | |||
There was a problem hiding this comment.
Rather than add a string option, let's add this to the options object, for future extensibility.
|
|
||
| ## Rule Details | ||
|
|
||
| In JSX when using a literal string you can wrap it in a JSX container `{'TEXT'}`. This rules by default requires that you wrap all literal strings. | ||
| Prevents any odd artifacts of highlighters if your unwrapped string contains an enclosing character like `'` in contractions and enforces consistency. |
There was a problem hiding this comment.
ftr tho, this shouldn't ever happen, since straight quotes are typographically incorrect - and this would be a bug in the highlighter. I'm not sure this is worth mentioning.
There was a problem hiding this comment.
this is the original text, essentially, with some modifications because of the different structure. If what you're saying is true, then this rule has/had no purpose.
There was a problem hiding this comment.
It still has many purposes; but dealing with quotes isn't one of them imo :-)
Fine to leave the text as-is.
docs/rules/jsx-no-literals.md
Outdated
| To use, you can specify like the following: | ||
|
|
||
| ```json | ||
| "react/jsx-no-literals": [{"noStrings": false}] |
There was a problem hiding this comment.
uhhhh, because i had a mind blank.
|
thanks for the feedback. what else would you like for this one? |
|
Thanks! |
Hey,
I was going to make a separate plugin to do this, but I feel like it can fit quite nicely here.
I've added an option to disallow all string literals in components. We translate all text inside our components, so don't want any strings in the JSX, as they then cannot be translated.
Strings are still allowed inside of function calls inside of
JSXExpressionContainers so that translation systems requiring a string key can still be used.