Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: removed invasive logging in transport/http/headers.go #2089

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

Dogild
Copy link
Contributor

@Dogild Dogild commented Aug 4, 2021

Removed the log when http2 pseudo headers were removed in the HTTP transport. This method is called in the hot path and this logging was quite invasive for services.

  • Description and context for reviewers: one partner, one stranger
  • Docs (package doc)
  • Entry in CHANGELOG.md (no need - not yet released)

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #2089 (6dea28b) into dev (f626339) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2089      +/-   ##
==========================================
- Coverage   87.60%   87.59%   -0.02%     
==========================================
  Files         247      247              
  Lines       13732    13731       -1     
==========================================
- Hits        12030    12027       -3     
- Misses       1322     1323       +1     
- Partials      380      381       +1     
Impacted Files Coverage Δ
transport/http/header.go 100.00% <100.00%> (ø)
peer/hashring32/internal/hashring32/hashring32.go 96.21% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f626339...6dea28b. Read the comment docs.

@Dogild Dogild merged commit 3835140 into dev Aug 4, 2021
@Dogild Dogild deleted the loggingInvasive branch August 4, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants