Skip to content

Commit ef2abc4

Browse files
Felipe Balbinsekhar
authored andcommitted
usb: dwc3: gadget: don't leave locks held
prevent a lock leak by making sure it's disabled in the error path. Signed-off-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
1 parent cb2050d commit ef2abc4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/usb/dwc3/gadget.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,6 +1639,7 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
16391639
ret = dwc3_device_reinit(dwc);
16401640
if (ret) {
16411641
dev_err(dwc->dev, "device reinit failed\n");
1642+
spin_unlock_irqrestore(&dwc->lock, flags);
16421643
return ret;
16431644
}
16441645

@@ -1647,6 +1648,7 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
16471648
ret = dwc3_gadget_restart(dwc);
16481649
if (ret) {
16491650
dev_err(dwc->dev, "failed to re-init gadget\n");
1651+
spin_unlock_irqrestore(&dwc->lock, flags);
16501652
return ret;
16511653
}
16521654

0 commit comments

Comments
 (0)