From b86722a921aeefcd616944907a2af070075b8200 Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Wed, 7 Oct 2020 09:11:18 +0900 Subject: [PATCH] feat(import): use core rule instead of plugin rule The `eslint-plugin-import` document says: > If the core ESLint version is good enough (...), keep it and don't use this. Note that `@typescript-eslint/no-duplicate-imports` also is present now. --- rules/core/es6.js | 2 +- rules/plugins/import.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/rules/core/es6.js b/rules/core/es6.js index df43de0c..db0e4c07 100644 --- a/rules/core/es6.js +++ b/rules/core/es6.js @@ -12,7 +12,7 @@ module.exports = { "no-class-assign": "error", "no-const-assign": "error", "no-dupe-class-members": "error", - "no-duplicate-imports": "off", // => `import/no-duplicates` + "no-duplicate-imports": "error", "no-new-symbol": "error", "no-restricted-exports": "off", "no-restricted-imports": "off", diff --git a/rules/plugins/import.js b/rules/plugins/import.js index 93e8b935..b39d2eef 100644 --- a/rules/plugins/import.js +++ b/rules/plugins/import.js @@ -24,6 +24,7 @@ module.exports = { "import/no-cycle": "error", "import/no-default-export": "off", "import/no-deprecated": "error", + "import/no-duplicates": "off", // use core rule `no-duplicate-imports` "import/no-dynamic-require": "warn", "import/no-extraneous-dependencies": [ "error",