From a7e8ac923632f0ef1db5d70d5b06b79f895d6de8 Mon Sep 17 00:00:00 2001 From: Alexander Petrukhin Date: Fri, 15 Mar 2024 00:19:32 +0300 Subject: [PATCH 1/2] [cms] add version to Node in Maintenance API (#2788) --- ydb/core/cms/api_adapters.cpp | 1 + ydb/public/api/protos/draft/ydb_maintenance.proto | 1 + 2 files changed, 2 insertions(+) diff --git a/ydb/core/cms/api_adapters.cpp b/ydb/core/cms/api_adapters.cpp index 18fe27185554..55572dbb9931 100644 --- a/ydb/core/cms/api_adapters.cpp +++ b/ydb/core/cms/api_adapters.cpp @@ -163,6 +163,7 @@ class TListClusterNodes: public TAdapterActor< out.set_host(in.Host); out.set_port(in.IcPort); out.set_state(ConvertNodeState(in.State)); + out.set_version(in.Version); *out.mutable_start_time() = TimeUtil::MicrosecondsToTimestamp(in.StartTime.GetValue()); auto& location = *out.mutable_location(); diff --git a/ydb/public/api/protos/draft/ydb_maintenance.proto b/ydb/public/api/protos/draft/ydb_maintenance.proto index 8dc461221314..1c30df661848 100644 --- a/ydb/public/api/protos/draft/ydb_maintenance.proto +++ b/ydb/public/api/protos/draft/ydb_maintenance.proto @@ -43,6 +43,7 @@ message Node { } // start_time defines time when node was registered in cms. google.protobuf.Timestamp start_time = 8; + string version = 9; } message ListClusterNodesRequest { From ead5bcaea2c2f905942b200eac03da7f2b30d316 Mon Sep 17 00:00:00 2001 From: Alexander Petrukhin Date: Fri, 15 Mar 2024 15:05:13 +0300 Subject: [PATCH 2/2] [cms] add comment for 'version' in maintenance api (#2817) --- ydb/public/api/protos/draft/ydb_maintenance.proto | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ydb/public/api/protos/draft/ydb_maintenance.proto b/ydb/public/api/protos/draft/ydb_maintenance.proto index 1c30df661848..c37356b98527 100644 --- a/ydb/public/api/protos/draft/ydb_maintenance.proto +++ b/ydb/public/api/protos/draft/ydb_maintenance.proto @@ -43,6 +43,8 @@ message Node { } // start_time defines time when node was registered in cms. google.protobuf.Timestamp start_time = 8; + // version defines YDB version for current Node. + // For example, 'ydb-stable-24-1'. string version = 9; }