Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccountVaultPosition.balanceProfit returns inaccurate results when testing deposits #123

Open
bsamuels453 opened this issue Dec 10, 2021 · 2 comments
Open

AccountVaultPosition.balanceProfit returns inaccurate results when testing deposits #123

bsamuels453 opened this issue Dec 10, 2021 · 2 comments

Comments

@bsamuels453
Copy link

When performing a basic deposit() test, AccountVaultPosition.balanceProfit records the deposited amount as profit.

This value should be 0 as there has been no profit recognized by the vault in the conditions set up by the test.
@0xkofee
Copy link

0xkofee commented Apr 30, 2022

seems this todo is gone. can we close?

@AlexNi245
Copy link

I think this one is still not solved. The test this issue is about is commented out. You can find it at line 24 in this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bsamuels453 @AlexNi245 @0xkofee