Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml:308-310: Upgrade Qulice to 0.16. Fix... #584

Closed
davvd opened this issue Feb 10, 2016 · 14 comments
Closed

pom.xml:308-310: Upgrade Qulice to 0.16. Fix... #584

davvd opened this issue Feb 10, 2016 · 14 comments

Comments

@davvd
Copy link

davvd commented Feb 10, 2016

Puzzle 558-ffd45315 in pom.xml:308-310 has to be resolved: Upgrade Qulice to 0.16. Fix all checkstyle violations (mostly AtclauseOrderCheck). Fix or add puzzle for PMD, findbugs and other types of violations.... The puzzle was created by Maksimenko Vladimir on 8-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@essobedo This task is yours, please go ahead keeping in mind this. If any questions, don't hesitate to ask right here... Task's budget is 30 mins (see this for explanation)

@essobedo
Copy link
Contributor

@davvd the PR is ready to be reviewed thx in advance

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@yegor256 since the ticket has no milestone I set it to 1.0

@davvd davvd added this to the 1.0 milestone Feb 10, 2016
@essobedo
Copy link
Contributor

@davvd The PR has been merged, could you please close the ticket and proceed with the QA. Thank you in advance.

@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

1 similar comment
@essobedo
Copy link
Contributor

@davvd please close the ticket and proceed with the QA.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 The issue is closed

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Quality is good.

@ypshenychka thank you, good quality is always good ;)

@essobedo
Copy link
Contributor

@davvd everything is ok here could you please proceed?

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@essobedo I added 10 mins to @ypshenychka (for QA review) in transaction 78708279... Many thanks! 30 mins were added to your account in Transaction ID 78708285 (task took 402 hours and 21 mins)... added +30 to your rating, now it is equal to +195

@essobedo
Copy link
Contributor

@davvd thank you very much!

@davvd
Copy link
Author

davvd commented Feb 29, 2016

@davvd thank you very much!

@essobedo sure, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants