From 889b0481badf75b1453b9e73429ca6b4961304cd Mon Sep 17 00:00:00 2001
From: Stig Johan Berggren <stigjb@gmail.com>
Date: Tue, 5 May 2020 12:44:26 +0200
Subject: [PATCH 1/3] Add class, id and placeholder properties to Select

---
 yew-components/src/select.rs | 45 ++++++++++++++++++++++++++++++++++--
 1 file changed, 43 insertions(+), 2 deletions(-)

diff --git a/yew-components/src/select.rs b/yew-components/src/select.rs
index 1e1a003993a..d59543ea9b3 100644
--- a/yew-components/src/select.rs
+++ b/yew-components/src/select.rs
@@ -66,6 +66,15 @@ pub struct Props<T: Clone> {
     /// Options are available to choose.
     #[prop_or_default]
     pub options: Vec<T>,
+    /// Classes applied to the `<select>` tag
+    #[prop_or_default]
+    pub classes: String,
+    /// ID for the `<select>` tag
+    #[prop_or_default]
+    pub id: String,
+    /// Placeholder value, shown at the top as a disabled option
+    #[prop_or(String::from("↪"))]
+    pub placeholder: String,
     /// Callback to handle changes.
     pub on_change: Callback<T>,
 }
@@ -124,9 +133,15 @@ where
         };
 
         html! {
-            <select ref=self.select_ref.clone() disabled=self.props.disabled onchange=self.on_change()>
+            <select
+                ref=self.select_ref.clone()
+                id=self.props.id.clone()
+                class=self.props.classes.clone()
+                disabled=self.props.disabled
+                onchange=self.on_change()
+            >
                 <option value="" disabled=true selected=selected.is_none()>
-                    { "↪" }
+                    { self.props.placeholder.clone() }
                 </option>
                 { for self.props.options.iter().map(view_option) }
             </select>
@@ -160,4 +175,30 @@ mod tests {
             <Select<u8> on_change=on_change />
         };
     }
+
+    #[test]
+    fn can_create_select_with_class() {
+        let on_change = Callback::<u8>::default();
+        let class = "form-control";
+        html! {
+            <Select<u8> on_change=on_change classes=class />
+        };
+    }
+
+    #[test]
+    fn can_create_select_with_id() {
+        let on_change = Callback::<u8>::default();
+        let id = "test-select";
+        html! {
+            <Select<u8> on_change=on_change id=id />
+        };
+    }
+
+    #[test]
+    fn can_create_select_with_placeholder() {
+        let on_change = Callback::<u8>::default();
+        html! {
+            <Select<u8> on_change=on_change placeholder="--Please choose an option--" />
+        };
+    }
 }

From e0603915fb32814894cfa5f80eea7867a922c43f Mon Sep 17 00:00:00 2001
From: Stig Johan Berggren <stigjb@gmail.com>
Date: Tue, 5 May 2020 12:50:28 +0200
Subject: [PATCH 2/3] Inline attributes

---
 yew-components/src/select.rs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/yew-components/src/select.rs b/yew-components/src/select.rs
index d59543ea9b3..bdeb3e15e61 100644
--- a/yew-components/src/select.rs
+++ b/yew-components/src/select.rs
@@ -179,18 +179,16 @@ mod tests {
     #[test]
     fn can_create_select_with_class() {
         let on_change = Callback::<u8>::default();
-        let class = "form-control";
         html! {
-            <Select<u8> on_change=on_change classes=class />
+            <Select<u8> on_change=on_change classes="form-control" />
         };
     }
 
     #[test]
     fn can_create_select_with_id() {
         let on_change = Callback::<u8>::default();
-        let id = "test-select";
         html! {
-            <Select<u8> on_change=on_change id=id />
+            <Select<u8> on_change=on_change id="test-select" />
         };
     }
 

From 3411bba898aa32179774a05e97984e2ae8305782 Mon Sep 17 00:00:00 2001
From: Stig Johan Berggren <stigjb@gmail.com>
Date: Wed, 6 May 2020 11:52:56 +0200
Subject: [PATCH 3/3] Rename classes to class

---
 yew-components/src/select.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/yew-components/src/select.rs b/yew-components/src/select.rs
index bdeb3e15e61..45f983bac34 100644
--- a/yew-components/src/select.rs
+++ b/yew-components/src/select.rs
@@ -68,7 +68,7 @@ pub struct Props<T: Clone> {
     pub options: Vec<T>,
     /// Classes applied to the `<select>` tag
     #[prop_or_default]
-    pub classes: String,
+    pub class: String,
     /// ID for the `<select>` tag
     #[prop_or_default]
     pub id: String,
@@ -136,7 +136,7 @@ where
             <select
                 ref=self.select_ref.clone()
                 id=self.props.id.clone()
-                class=self.props.classes.clone()
+                class=self.props.class.clone()
                 disabled=self.props.disabled
                 onchange=self.on_change()
             >
@@ -180,7 +180,7 @@ mod tests {
     fn can_create_select_with_class() {
         let on_change = Callback::<u8>::default();
         html! {
-            <Select<u8> on_change=on_change classes="form-control" />
+            <Select<u8> on_change=on_change class="form-control" />
         };
     }