Fix near me searches sometimes not triggering HTML5 geolocation
#1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
commented
Mar 24, 2023
tmeyer2115
approved these changes
Mar 24, 2023
Merged
oshi97
added a commit
that referenced
this pull request
Mar 24, 2023
### Fixes * Fix `near me` searches not triggering HTML5 geolocation in certain scenarios (#1809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to the latest version of core, which has been updated to include
inputIntentson search-core's
AutocompleteResultthat were expected by the SDK but did not exist before.search-core has been updated from v1.6 to v2.2, however none of the breaking changes affect the SDK's
external interfaces. The SDK's internal filter registry has been updated to support the breaking static filter changes from v2.0 of search-core.
T=TECHOPS-8462
TEST=auto,manual
hook local SDK up to affected techops site. see that geolocation now fires for edge case where a user
clicks on an autocomplete option for a "near me" search as opposed to typing it out manually.
see that selecting a single static filter works as expected
multiple static filters from the same field works as expected (are $or-ed together)
and multiple static filters from different fields works as expected (are $and-ed together)