Pass CloudRegion to Search Core #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses the CloudRegion injected during the build process and passes it to the Search Core config. It also passes the environment using the environment provided from the config rather than manually constructing the endpoints. J=BACK-2269 TEST=manual Manually tested the eu assets with an eu test site and confirmed the requests were being made correctly. Also tested the search-bar only integration in eu. Confirmed the us build still worked as expected.
benmcginnis
approved these changes
May 5, 2023
EmilyZhang777
approved these changes
May 5, 2023
EmilyZhang777
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the CloudRegion injected during the build
process and passes it to the Search Core config. It also
passes the environment using the environment provided from
the config rather than manually constructing the endpoints.
J=BACK-2269
TEST=manual
Manually tested the eu assets with an eu test site
and confirmed the requests were being made correctly. Also
tested the search-bar only integration in eu. Confirmed the
us build still worked as expected.