Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate EU artifact in github actions #1822

Merged
merged 1 commit into from
May 5, 2023
Merged

Create separate EU artifact in github actions #1822

merged 1 commit into from
May 5, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented May 5, 2023

Previously the US and EU builds were using the same artifact, but
were using separate directories. There was an issue with the
acceptance tests which I suspect was a bug with this approach, so
I am updating the flow to use separate artificts for the different
regions instead.

J=BACK-2268
TEST=none

I will create a test tag version and confirm the deploy works
correctly

@cea2aj
Create seprate EU artifact in github actions
e96a3d6 
Previously the US and EU builds were using the same artifact, but
were using separate directories. There was an issue with the
acceptance tests which I suspect was a bug with this approach, so
I am updating the flow to use separate artificts for the different
regions instead.

J=BACK-2268
TEST=none

I will create a test tag version and confirm the deploy works
correctly
@cea2aj cea2aj changed the title Create seprate EU artifact in github actions Create seprate EU artifacts in github actions May 5, 2023
@cea2aj cea2aj changed the title Create seprate EU artifacts in github actions Create separate EU artifacts in github actions May 5, 2023
@cea2aj cea2aj changed the title Create separate EU artifacts in github actions Create separate EU artifact in github actions May 5, 2023
@coveralls
Copy link

Coverage Status

Coverage: 61.394%. Remained the same when pulling e96a3d6 on dev/eu-dist-fix into 8ab587b on develop.

@cea2aj cea2aj merged commit 1b10c14 into develop May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmcginnis benmcginnis benmcginnis approved these changes

@EmilyZhang777 EmilyZhang777 EmilyZhang777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cea2aj @coveralls @benmcginnis @EmilyZhang777