Version 1.16.0 #1824
Merged
Version 1.16.0 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master (v1.15.1) into develop
Merge master (v1.15.2) into develop
…elop Merge master (v1.15.4) into develop
…elop Merge master (v1.15.5) into develop
Add support for a CLOUD_REGION env variable which allows either US or EU to be set as the cloud region. Defaults to US. J=BACK-2269 TEST=manual Manually ran a build with the CLOUD_REGION env variable set to US and EU and confirmed the CLOUD_REGION variable was set correctly in dist/answers.js
Previously the GH actions were syncing the US assets to GCP. This change updates the actions so that a seprate EU build is ran, and only those assets are synced to GCP. Also, remove the syncing of assets from dev branches. J=BACK-2268 TEST=none I will test this with a test version (e.g. 0.0.10) and confirm the build works as expected
This change uses the CloudRegion injected during the build process and passes it to the Search Core config. It also passes the environment using the environment provided from the config rather than manually constructing the endpoints. J=BACK-2269 TEST=manual Manually tested the eu assets with an eu test site and confirmed the requests were being made correctly. Also tested the search-bar only integration in eu. Confirmed the us build still worked as expected.
Fix passing of cloud region env variable J=BACK-2268 TEST=none I will create a test version tag and confirm it is passed correctly in github actions
Previously the US and EU builds were using the same artifact, but were using separate directories. There was an issue with the acceptance tests which I suspect was a bug with this approach, so I am updating the flow to use separate artifacts for the different regions instead. J=BACK-2268 TEST=none I will create a test tag version and confirm the deploy works correctly
Bump the version number and update search-core J=BACK-2236 TEST=manual Ran a build an confirmed a test site worked with EU and the EU builds
benmcginnis
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Assets are now available through our EU CDN at https://assets.eu.sitescdn.net/. Assets hosted in the EU CDN for versions 1.16.0 and later use the EU search endpoints.