Merge master (v1.16.5) into develop #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
### Changes Assets are now available through our EU CDN at [https://assets.eu.sitescdn.net/](https://assets.eu.sitescdn.net/). Assets hosted in the EU CDN for versions 1.16.0 and later use the EU search endpoints.
When the cloud region is EU, send analytics events to https://www.eu.yextevents.com J=BACK-2362 TEST=manual Build EU and US versions locally. Connected them to a test jambo site and confirmed the EU and US events fire properly. Checked the user_events table in the EU and confirmed the events are there.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ounts (#1830) The current implementation of verticalresultcount.hbs unnecessarily uses an aria-label and aria-hidden property to handle text that is already accessible for a non-interactive element. J=TECHOPS-9030 Co-authored-by: Ben McGinnis <bmcginnis@yext.com>
# Version 1.16.1 ### Features Assets hosted in the EU will now properly send analytics events to the EU hosted analytics domain (#1827)
Create main.yml
techops10133: fix multiple search bars on a page
fix breaking unit test and upgdated package version
This PR bumps the `search-core` version to v2.4.0 to get support for new Rich Text & Markdown field types returned as raw html in direct answers (see [release notes](https://github.com/yext/search-core/releases/tag/v2.4.0)). We had already added [support](yext/answers-hitchhiker-theme#1138) to render these fields in the Theme, but without the Core update, a search that returns an `html` field type gives an error and doesn't actually get rendered. J=TECHOPS-10638 TEST=manual Point the site from the techops to a locally served version of the SDK with this version bump and see that an HTML field type for a featured snippet direct answer is properly rendered instead of throwing an error. <img width="1728" alt="Screenshot 2023-11-30 at 4 55 46 PM" src="https://github.com/yext/answers-search-ui/assets/88398086/82233e9d-9d1e-4e26-960a-8b579a0eac4c"> Note: this PR is the same as #1843, but with a corrected version bump (v1.16.4 instead of v1.16.3)
### Fixes - Updated `@yext/search-core` to v2.4.0 to properly support new Rich Text & Markdown field types returned as raw html in direct answers (#1847)
Upgrade `@babel/traverse` from v7.17.10 to 7.23.5 to address a critical vulnerability in the package. J=VULN-38480 TEST=auto
### Fixes - Upgraded `@babel/traverse` version to address a vulnerability in the package (#1851)
github-actions
bot
restored the
dev/merge-v1.16.5-dc3b171-into-develop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master (v1.16.5) into develop