Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(httplib):Fix the problem that CreateFile2 in mmap::open fails to … #1973

Closed
wants to merge 1 commit into from
Closed

Conversation

cool2528
Copy link

@cool2528 cool2528 commented Nov 8, 2024

When the open path exists in Chinese when CreateFile2 in un icode encoding the original way is invalid, must open the failure although this situation is rarely used but unfortunately that person appeared is me, so fix this problem!

yhirose added a commit that referenced this pull request Nov 13, 2024
yhirose added a commit that referenced this pull request Nov 13, 2024
yhirose added a commit that referenced this pull request Nov 13, 2024
yhirose added a commit that referenced this pull request Nov 13, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
@yhirose yhirose mentioned this pull request Nov 14, 2024
@yhirose
Copy link
Owner

yhirose commented Nov 14, 2024

@cool2528 thanks for the pull request. I fixed this problem at #1976.

@yhirose yhirose closed this Nov 14, 2024
yhirose added a commit that referenced this pull request Nov 14, 2024
* Fix #1973

* Fixed problems with 'Language for non-Unicode programs' setting on Windows

* Fix problems on English locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants