Skip to content

Conversation

@ASuresh0524
Copy link
Collaborator

  • Add ColQwenRAG class with easy-to-use CLI for multimodal PDF retrieval
  • Support for both ColQwen2 and ColPali models with automatic device selection
  • MPS optimization for Apple Silicon with memory-efficient loading
  • Complete pipeline: PDF→images→embeddings→HNSW index→search
  • Multi-vector indexing for fine-grained document matching
  • Comprehensive user guide and reproduction test script
  • Resolves [ColQwen doc and enhance support] #119: ColQwen Doc and Support Management

Features:

  • python -m apps.colqwen_rag build --pdfs ./pdfs/ --index my_index
  • python -m apps.colqwen_rag search my_index "query text"
  • python -m apps.colqwen_rag ask my_index --interactive
  • Automatic CPU fallback for memory constraints
  • Robust error handling and progress tracking

Checklist

  • Tests pass (uv run pytest)
  • Code formatted (ruff format and ruff check)
  • Pre-commit hooks pass (pre-commit run --all-files)

- Add ColQwenRAG class with easy-to-use CLI for multimodal PDF retrieval
- Support for both ColQwen2 and ColPali models with automatic device selection
- MPS optimization for Apple Silicon with memory-efficient loading
- Complete pipeline: PDF→images→embeddings→HNSW index→search
- Multi-vector indexing for fine-grained document matching
- Comprehensive user guide and reproduction test script
- Resolves #119: ColQwen Doc and Support Management

Features:
- python -m apps.colqwen_rag build --pdfs ./pdfs/ --index my_index
- python -m apps.colqwen_rag search my_index "query text"
- python -m apps.colqwen_rag ask my_index --interactive
- Automatic CPU fallback for memory constraints
- Robust error handling and progress tracking
- Add noqa comments for E402 errors (imports after sys.path modifications)
- Remove unused variable assignment in colqwen_rag.py
- Use importlib.util.find_spec for dependency checks instead of unused imports
- Fix import ordering in test_colqwen_reproduction.py
@yichuan-w
Copy link
Owner

The faiss submodule still seems to have some problem, we need to remember to submodule update

@yichuan-w
Copy link
Owner

@ASuresh0524

@ASuresh0524
Copy link
Collaborator Author

hmm @yichuan-w okay sounds good will look into it

- Add apps/image_rag.py for indexing and searching images using CLIP embeddings
- Supports text-based image search queries
- Uses CLIP ViT-L/14 model via sentence-transformers
- Follows the same pattern as other RAG apps in the apps directory
- Addresses feature request for CLIP support in apps (issue #94)

# Load CLIP model
print("🔍 Loading CLIP model...")
model = SentenceTransformer(self.embedding_model_default)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are U sure we can run this? you should test yourself on some dataset, the default model should be clip stuff.

@yichuan-w
Copy link
Owner

@ASuresh0524 Thanks for the PR make sure the faiss submodule is correct, and I think we create an unnecessary faiss submodule update

@ASuresh0524
Copy link
Collaborator Author

@ASuresh0524 Thanks for the PR make sure the faiss submodule is correct, and I think we create an unnecessary faiss submodule update

Sounds good, will fix this tomorrow

Reset faiss submodule to match main branch to avoid unnecessary changes
@ASuresh0524
Copy link
Collaborator Author

@yichuan-w think i fixed it let me know if it looks good

@yichuan-w
Copy link
Owner

@ASuresh0524 can you add a brief introduction to Colqwen and how to use in the Readme?
Then feel free to merge yourself. Thanks!!
Remember to squash merge though

@ASuresh0524
Copy link
Collaborator Author

sounds good! will work on this for the next day to make it in-depth and squash merge it as well

Add brief introduction and usage guide for ColQwen integration,
similar to other RAG application sections in the README.

- Quick start examples for building, searching, and interactive Q&A
- Setup instructions with prerequisites
- Model options (ColQwen2 vs ColPali)
- Link to detailed ColQwen guide
@yichuan-w
Copy link
Owner

plz fix CI @ASuresh0524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ColQwen doc and enhance support]

3 participants