From 73b40b2db2ffc06347911f8136cb822117299d85 Mon Sep 17 00:00:00 2001 From: Sergei Predvoditelev Date: Thu, 18 Dec 2025 23:15:18 +0300 Subject: [PATCH 1/2] Fix "GROUP BY" builder ignoring parameters --- CHANGELOG.md | 2 +- src/DQLQueryBuilder.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bdd50be2..0ababe81 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## 2.0.1 under development -- no changes in this release. +- Bug #413: Fix "GROUP BY" builder ignoring parameters (@vjik) ## 2.0.0 December 05, 2025 diff --git a/src/DQLQueryBuilder.php b/src/DQLQueryBuilder.php index d4ce9a68..b95c5f0d 100644 --- a/src/DQLQueryBuilder.php +++ b/src/DQLQueryBuilder.php @@ -45,7 +45,7 @@ public function build(QueryInterface $query, array $params = []): array $this->buildFrom($query->getFrom(), $params), $this->buildJoin($query->getJoins(), $params), $this->buildWhere($query->getWhere(), $params), - $this->buildGroupBy($query->getGroupBy()), + $this->buildGroupBy($query->getGroupBy(), $params), $this->buildHaving($query->getHaving(), $params), $this->buildFor($query->getFor()), ]; From 336b5caac70a3851bb6f07d0bdef1b010e69f50a Mon Sep 17 00:00:00 2001 From: Sergei Predvoditelev Date: Thu, 18 Dec 2025 23:24:55 +0300 Subject: [PATCH 2/2] fix --- src/DQLQueryBuilder.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/DQLQueryBuilder.php b/src/DQLQueryBuilder.php index b95c5f0d..808b3a9c 100644 --- a/src/DQLQueryBuilder.php +++ b/src/DQLQueryBuilder.php @@ -62,16 +62,6 @@ public function build(QueryInterface $query, array $params = []): array } } - $groupBy = $query->getGroupBy(); - - if (!empty($groupBy)) { - foreach ($groupBy as $expression) { - if ($expression instanceof ExpressionInterface) { - $this->buildExpression($expression, $params); - } - } - } - $union = $this->buildUnion($query->getUnions(), $params); if ($union !== '') {