Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append typescript definition file #39

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Append typescript definition file #39

merged 1 commit into from
Sep 29, 2018

Conversation

jbdemonte
Copy link
Contributor

#13

@yjose yjose self-requested a review September 23, 2018 00:21
yjose
yjose approved these changes Sep 29, 2018
View reviewed changes
Copy link
Owner

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , just the trigger prop is not required, I will update it after the merge

@yjose yjose merged commit 1f1b045 into yjose:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjose yjose yjose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbdemonte @yjose