Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo has implicit dependencies on lib0/y-protocols #25

Closed
tommoor opened this issue Oct 13, 2020 · 3 comments
Closed

Repo has implicit dependencies on lib0/y-protocols #25

tommoor opened this issue Oct 13, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tommoor
Copy link
Contributor

tommoor commented Oct 13, 2020

Describe the bug
Repo has implicit dependencies on lib0/y-protocols, it's not clear exactly what the requirements are to work on the repo independently.

To Reproduce
Steps to reproduce the behavior:

  1. clone repo
  2. run npm install
  3. run npm run dist or npm run debug
  4. Fails with error
[!] Error: Could not load /Users/tom/projects/y-prosemirror/../lib0/testing.js (imported by test/index.js): ENOENT: no such file or directory, open '/Users/tom/projects/y-prosemirror/../lib0/testing.js'

Expected behavior

The repo should be useable and allow for development without additional repos implicitly required. Or, the development instructions should make it clear what the setup should be to allow for local development.

Screenshots

image

Additional context

Working on a fork to add additional functionality

@tommoor tommoor added the bug Something isn't working label Oct 13, 2020
@dmonad
Copy link
Member

dmonad commented Oct 13, 2020

Hey @tommoor , I double checked, and I don't think that lib0 is imported using a relative path (anymore?).

I certainly do something like that from time to time when I develop new features, and I might have accidentally committed that change. But the current master branch does not use relative paths to lib0: https://github.com/yjs/y-prosemirror/blob/master/test/index.js

Maybe you are on an old branch?

@tommoor
Copy link
Contributor Author

tommoor commented Oct 13, 2020

image

Branch is uptodate, I cloned yesterday. I'd recommend you give it a quick try in a fresh clone location. I agree that I can't find a reference to the relative path in the codebase 🤔

@dmonad dmonad closed this as completed in be02c7c Oct 13, 2020
@dmonad
Copy link
Member

dmonad commented Oct 13, 2020

So sorry about that -.-

So I wrote this bundler plugin that imports from relative positions. I haven't used it in a while, but it should only work when a environment flag is set. Seems I hastily ported the plugin and forgot to set the environment variable.

It is fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants