fix(ota): certificate signed by unknown authority

ym · ym · commit 40d8243112d9 · 2025-06-13T21:02:04.000Z
diff --git a/ota.go b/ota.go
@@ -126,12 +126,10 @@ func downloadFile(ctx context.Context, path string, url string, downloadProgress
 		return fmt.Errorf("error creating request: %w", err)
 	}
 
+	// TODO: set a separate timeout for the download but keep the TLS handshake short
+	// use Transport here will cause CA certificate validation failure so we temporarily removed it
 	client := http.Client{
-		// allow a longer timeout for the download but keep the TLS handshake short
 		Timeout: 10 * time.Minute,
-		Transport: &http.Transport{
-			TLSHandshakeTimeout: 1 * time.Minute,
-		},
 	}
 
 	resp, err := client.Do(req)

Original file line number	Diff line number	Diff line change
`@@ -126,12 +126,10 @@ func downloadFile(ctx context.Context, path string, url string, downloadProgress`
`126`	`126`	`return fmt.Errorf("error creating request: %w", err)`
`127`	`127`	`}`
`128`	`128`
	`129`	`+ // TODO: set a separate timeout for the download but keep the TLS handshake short`
	`130`	`+ // use Transport here will cause CA certificate validation failure so we temporarily removed it`
`129`	`131`	`client := http.Client{`
`130`		`- // allow a longer timeout for the download but keep the TLS handshake short`
`131`	`132`	`Timeout: 10 * time.Minute,`
`132`		`- Transport: &http.Transport{`
`133`		`- TLSHandshakeTimeout: 1 * time.Minute,`
`134`		`- },`
`135`	`133`	`}`
`136`	`134`
`137`	`135`	`resp, err := client.Do(req)`