From ff047f0b90b8855b36f3469e57b45e09950f56a9 Mon Sep 17 00:00:00 2001 From: Yoanm <4410697+yoanm@users.noreply.github.com> Date: Sun, 31 Mar 2024 15:24:49 +0200 Subject: [PATCH 1/5] reports-group actions v1 --- .github/workflows/CI.yml | 223 +----------------- .github/workflows/coverage-upload.yml | 53 +---- .github/workflows/pre-check-CI-updates.yml | 40 ++++ .github/workflows/reusable-CI-workflow.yml | 222 +++++++++++++++++ .../reusable-coverage-upload-workflow.yml | 67 ++++++ 5 files changed, 347 insertions(+), 258 deletions(-) create mode 100644 .github/workflows/pre-check-CI-updates.yml create mode 100644 .github/workflows/reusable-CI-workflow.yml create mode 100644 .github/workflows/reusable-coverage-upload-workflow.yml diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 6ebac4e..dfaa0eb 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -6,6 +6,14 @@ on: # Build any PRs and main branch changes types: - opened - synchronize + paths-ignore: + # In case of updates to those workflows, they must be pre-checked by `pre-check-CI-updates.yml` rather than this workflow ! + # Any updates on those workflows are expected to be restricted to those workflows only ! (no update on code for instance) + - '.github/workflows/pre-check-CI-updates.yml' + - '.github/workflows/CI.yml' + - '.github/workflows/coverage-upload.yml' + - '.github/workflows/reusable-CI-workflow.yml' + - '.github/workflows/reusable-coverage-upload-workflow.yml' push: branches: [ master ] schedule: @@ -21,214 +29,7 @@ env: jobs: tests: - name: UTs & FTs - Symfony ${{ matrix.symfony-version }} - runs-on: ubuntu-latest - env: - COVERAGE_TYPE: none - strategy: - fail-fast: true - max-parallel: 4 - matrix: - include: - # Bare minimum => Lowest versions allowed by composer config - - symfony-version: '4.4' - php-version: '8.0' - composer-flag: --prefer-lowest - # Up to date versions => Latest versions allowed by composer config - - symfony-version: '5.4' - php-version: '8.2' - # Late symfony migration => Lowest symfony version with latest minor php version allowed by composer config - - symfony-version: '4.4' - php-version: '8.2' - composer-flag: --prefer-lowest - # Late php migration => Latest symfony version with lowest minor php version allowed by composer config - - symfony-version: '5.4' - php-version: '8.0' - # Symfony 6.0 latest - - symfony-version: '6.0' - php-version: '8.2' - # Symfony 6.0 lowest - - symfony-version: '6.0' - php-version: '8.0' - composer-flag: --prefer-lowest - steps: - - name: Check out code - uses: actions/checkout@v4 - - - name: Enable coverage - if: ${{ matrix.php-version == '8.2' }} - run: | - echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV - echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV - - - name: Setup PHP ${{ matrix.php-version }} - uses: shivammathur/setup-php@v2 - env: - update: true # Always use latest available patch for the version - fail-fast: true # step will fail if an extension or tool fails to set up - with: - php-version: '${{ matrix.php-version }}' - tools: composer - coverage: ${{ env.COVERAGE_TYPE }} - - - name: Setup cache - id: cache - uses: actions/cache@v4 - with: - path: | - ~/.composer - ./vendor - # Clear the cache if composer json (as composer.lock is in the repo) has been updated - key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ matrix.composer-flag }}-${{ hashFiles('composer.json') }} - - - name: Build - run: | - SF_VERSION=${{ matrix.symfony-version }} - # Issue with ParamterBag below 4.4.30 => https://github.com/symfony/symfony/commit/3eca446b21607ea1c7a865ece2dd8254c33679cc - test '${{ matrix.symfony-version }}' = '4.4' && test '${{ matrix.php-version }}' = '8.2' && SF_VERSION=4.4.30 - composer require -W ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \ - symfony/http-foundation:^$SF_VERSION \ - symfony/http-kernel:^$SF_VERSION \ - symfony/config:^$SF_VERSION \ - symfony/dependency-injection:^$SF_VERSION \ - symfony/event-dispatcher:^$SF_VERSION \ - symfony/routing:^$SF_VERSION \ - && composer update ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \ - && make build - - - name: Tests - run: make test-unit && make test-functional - - - name: Create "unit tests" reports group - if: ${{ env.COVERAGE_TYPE == 'xdebug' }} - id: unit-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop - with: - name: unit-tests - format: clover - files: build/coverage-phpunit/unit.clover - flags: | - unit-tests - php-${{ matrix.php-version }} - sf-${{ matrix.symfony-version }} - path: build/coverage-groups - - - name: Create "functional tests" coverage group - if: ${{ env.COVERAGE_TYPE == 'xdebug' }} - id: functional-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop - with: - name: functional-tests - format: clover - files: | - build/coverage-phpunit/functional.clover - build/coverage-behat/clover.xml - flags: | - functional-tests - php-${{ matrix.php-version }} - sf-${{ matrix.symfony-version }} - path: build/coverage-groups - - - name: Upload coverage reports - if: ${{ env.COVERAGE_TYPE == 'xdebug' }} - uses: actions/upload-artifact@v4 - with: - name: coverage-groups-php${{ matrix.php-version }}-sf${{ matrix.symfony-version }} - path: build/coverage-groups - if-no-files-found: error - - static-checks: - name: Static checks - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Setup PHP 8.2 - uses: shivammathur/setup-php@v2 - with: - php-version: 8.2 # Latest supported - tools: composer - coverage: none - env: - # Always use latest available patch for the version - update: true - - - name: Setup cache - id: cache - uses: actions/cache@v4 - with: - path: | - ~/.composer - # Clear the cache if composer json (as composer.lock is in the repo) has been updated - key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }} - - - name: Build - run: make build - - - name: ComposerRequireChecker - uses: docker://webfactory/composer-require-checker:4.5.0 - - - name: Dependencies check - if: ${{ github.event_name == 'pull_request' }} - uses: actions/dependency-review-action@v4 - - nightly-tests: - name: Nightly - Symfony ${{ matrix.symfony-version }} - runs-on: ubuntu-latest - env: - COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+' - continue-on-error: true - needs: [ static-checks, tests ] - strategy: - fail-fast: false - max-parallel: 4 - matrix: - php-version: - - '8.3' # Current php dev version - symfony-version: - - '4.4' # Lowest LTS - - '5.4' # Latest LTS - - '6.0' # Current major version - include: - - symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version - php-version: '8.2' - - steps: - - name: Check out code - uses: actions/checkout@v4 - - - name: Setup PHP ${{ matrix.php-version }} - uses: shivammathur/setup-php@v2 - with: - php-version: '${{ matrix.php-version }}' - tools: composer - coverage: none - env: - # Always use latest available patch for the version - update: true - - - name: Setup cache - id: cache - uses: actions/cache@v4 - with: - path: | - ~/.composer - ./vendor - # Clear the cache if composer json (as composer.lock is in the repo) has been updated - key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }} - - - name: Build - run: | - composer config minimum-stability dev \ - && composer require -W ${{ env.COMPOSER_OPTIONS }} \ - symfony/http-foundation:^${{ matrix.symfony-version }} \ - symfony/http-kernel:^${{ matrix.symfony-version }} \ - symfony/config:^${{ matrix.symfony-version }} \ - symfony/dependency-injection:^${{ matrix.symfony-version }} \ - symfony/event-dispatcher:^${{ matrix.symfony-version }} \ - symfony/routing:^${{ matrix.symfony-version }} \ - && composer update ${{ env.COMPOSER_OPTIONS }} \ - && make build - - - name: Test - run: make test-unit && make test-functional + name: Tests + permissions: + contents: read + uses: ./.github/workflows/reusable-CI-workflow.yml diff --git a/.github/workflows/coverage-upload.yml b/.github/workflows/coverage-upload.yml index d80c7d6..9428e0d 100644 --- a/.github/workflows/coverage-upload.yml +++ b/.github/workflows/coverage-upload.yml @@ -1,57 +1,16 @@ -name: 'Coverage upload' +name: 'Coverage' on: workflow_run: workflows: ["CI"] types: [completed] jobs: - fetch-info: - name: Fetch triggering workflow metadata - runs-on: ubuntu-latest - permissions: - contents: read - checks: write # For the check run creation ! - steps: - - name: 'Check run ○' - uses: yoanm/temp-reports-group-workspace/.github/actions/attach-check-run-to-triggering-workflow-action@develop - with: - name: 'Fetch coverage info' - fails-on-triggering-workflow-failure: true - - - uses: yoanm/temp-reports-group-workspace/.github/actions/fetch-workflow-metadata-action@develop - id: fetch-workflow-metadata - - outputs: - commit-sha: ${{ steps.fetch-workflow-metadata.outputs.commit-sha }} - run-id: ${{ steps.fetch-workflow-metadata.outputs.run-id }} - - codacy-uploader: - name: Codacy - needs: [fetch-info] - uses: yoanm/temp-reports-group-workspace/.github/workflows/codacy-upload-from-artifacts.yml@develop - permissions: - contents: read - checks: write # For the check run creation ! - secrets: - PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} - with: - artifacts-pattern: coverage-groups-* - run-id: ${{ needs.fetch-info.outputs.run-id }} - - codecov-uploader: - name: Codecov - needs: [fetch-info] - uses: yoanm/temp-reports-group-workspace/.github/workflows/codecov-upload-from-artifacts.yml@develop + upload: + name: Upload permissions: contents: read checks: write # For the check run creation ! secrets: - TOKEN: ${{ secrets.CODECOV_TOKEN }} - with: - artifacts-pattern: coverage-groups-* - run-id: ${{ needs.fetch-info.outputs.run-id }} - override-commit: ${{ needs.fetch-info.outputs.commit-sha }} - override-branch: ${{ needs.fetch-info.outputs.branch }} - override-pr: ${{ needs.fetch-info.outputs.pr-number }} - override-build: ${{ needs.fetch-info.outputs.run-id }} - override-build-url: ${{ needs.fetch-info.outputs.run-url }} + CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + uses: ./.github/workflows/reusable-coverage-upload-workflow.yml diff --git a/.github/workflows/pre-check-CI-updates.yml b/.github/workflows/pre-check-CI-updates.yml new file mode 100644 index 0000000..701bf0c --- /dev/null +++ b/.github/workflows/pre-check-CI-updates.yml @@ -0,0 +1,40 @@ +name: 'Test CI updates' +# [DESCRIPTION] +# As CI workflow relies on `workflow_run` trigger for upload, this workflow is used in order to ease updates made on +# CI workflow (or linked workflows/actions). It's kind of pre-check to ensure once updates are merged on main branch, +# the `workflow_run` workflow execution will behave as expected. + +on: + pull_request: + types: + - opened + - synchronize + branches: [master] # Only for PR targeting master branch + paths: # /!\ Duplicate the same list as `on.pull_request.paths-ignore` property value for CI workflow ! + - '.github/workflows/pre-check-CI-updates.yml' # This workflow + - '.github/workflows/CI.yml' + - '.github/workflows/coverage-upload.yml' + - '.github/workflows/reusable-CI-workflow.yml' + - '.github/workflows/reusable-coverage-upload-workflow.yml' + +concurrency: + group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}" + cancel-in-progress: true + +jobs: + tests: + name: Tests + permissions: + contents: read + uses: ./.github/workflows/reusable-CI-workflow.yml + + upload: + name: Upload + needs: [tests] + permissions: + contents: read + checks: write # For the check run creation ! + secrets: + CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + uses: ./.github/workflows/reusable-coverage-upload-workflow.yml diff --git a/.github/workflows/reusable-CI-workflow.yml b/.github/workflows/reusable-CI-workflow.yml new file mode 100644 index 0000000..444c14f --- /dev/null +++ b/.github/workflows/reusable-CI-workflow.yml @@ -0,0 +1,222 @@ +name: 'CI reusable workflow' + +on: + workflow_call: + +env: + TEST_OUTPUT_STYLE: pretty + COMPOSER_OPTIONS: --optimize-autoloader + +jobs: + tests: + name: PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }} + runs-on: ubuntu-latest + env: + COVERAGE_TYPE: none + strategy: + fail-fast: true + max-parallel: 4 + matrix: + include: + # Bare minimum => Lowest versions allowed by composer config + - symfony-version: '4.4' + php-version: '8.0' + composer-flag: --prefer-lowest + # Up to date versions => Latest versions allowed by composer config + - symfony-version: '5.4' + php-version: '8.2' + # Late symfony migration => Lowest symfony version with latest minor php version allowed by composer config + - symfony-version: '4.4' + php-version: '8.2' + composer-flag: --prefer-lowest + # Late php migration => Latest symfony version with lowest minor php version allowed by composer config + - symfony-version: '5.4' + php-version: '8.0' + # Symfony 6.0 latest + - symfony-version: '6.0' + php-version: '8.2' + # Symfony 6.0 lowest + - symfony-version: '6.0' + php-version: '8.0' + composer-flag: --prefer-lowest + steps: + - name: Check out code + uses: actions/checkout@v4 + + - name: Enable coverage + if: ${{ matrix.php-version == '8.2' }} + run: | + echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV + echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV + + - name: Setup PHP ${{ matrix.php-version }} + uses: shivammathur/setup-php@v2 + env: + update: true # Always use latest available patch for the version + fail-fast: true # step will fail if an extension or tool fails to set up + with: + php-version: '${{ matrix.php-version }}' + tools: composer + coverage: ${{ env.COVERAGE_TYPE }} + + - name: Setup cache + id: cache + uses: actions/cache@v4 + with: + path: | + ~/.composer + ./vendor + # Clear the cache if composer json (as composer.lock is in the repo) has been updated + key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ matrix.composer-flag }}-${{ hashFiles('composer.json') }} + + - name: Build + run: | + SF_VERSION=${{ matrix.symfony-version }} + # Issue with ParamterBag below 4.4.30 => https://github.com/symfony/symfony/commit/3eca446b21607ea1c7a865ece2dd8254c33679cc + test '${{ matrix.symfony-version }}' = '4.4' && test '${{ matrix.php-version }}' = '8.2' && SF_VERSION=4.4.30 + composer require -W ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \ + symfony/http-foundation:^$SF_VERSION \ + symfony/http-kernel:^$SF_VERSION \ + symfony/config:^$SF_VERSION \ + symfony/dependency-injection:^$SF_VERSION \ + symfony/event-dispatcher:^$SF_VERSION \ + symfony/routing:^$SF_VERSION \ + && composer update ${{ env.COMPOSER_OPTIONS }} ${{ matrix.composer-flag }} \ + && make build + + - name: Tests + run: make test-unit && make test-functional + + - name: Create "unit tests" reports group + if: ${{ env.COVERAGE_TYPE == 'xdebug' }} + id: unit-tests-coverage-group + uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop + with: + name: unit-tests + format: clover + files: build/coverage-phpunit/unit.clover + flags: | + unit-tests + php-${{ matrix.php-version }} + sf-${{ matrix.symfony-version }} + path: build/coverage-groups + + - name: Create "functional tests" reports group + if: ${{ env.COVERAGE_TYPE == 'xdebug' }} + id: functional-tests-coverage-group + uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop + with: + name: functional-tests + format: clover + files: | + build/coverage-phpunit/functional.clover + build/coverage-behat/clover.xml + flags: | + functional-tests + php-${{ matrix.php-version }} + sf-${{ matrix.symfony-version }} + path: build/coverage-groups + + - name: Upload coverage reports + if: ${{ env.COVERAGE_TYPE == 'xdebug' }} + uses: actions/upload-artifact@v4 + with: + name: coverage-groups-php${{ matrix.php-version }}-sf${{ matrix.symfony-version }} + path: build/coverage-groups + if-no-files-found: error + + static-checks: + name: Static analysis + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - name: Setup PHP 8.2 + uses: shivammathur/setup-php@v2 + with: + php-version: 8.2 # Latest supported + tools: composer + coverage: none + env: + # Always use latest available patch for the version + update: true + + - name: Setup cache + id: cache + uses: actions/cache@v4 + with: + path: | + ~/.composer + # Clear the cache if composer json (as composer.lock is in the repo) has been updated + key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }} + + - name: Build + run: make build + + - name: ComposerRequireChecker + uses: docker://webfactory/composer-require-checker:4.5.0 + + - name: Dependencies check + if: ${{ github.event_name == 'pull_request' }} + uses: actions/dependency-review-action@v4 + + nightly-tests: + name: Nightly - PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }} + runs-on: ubuntu-latest + env: + COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+' + continue-on-error: true + needs: [ static-checks, tests ] + strategy: + fail-fast: false + max-parallel: 4 + matrix: + php-version: + - '8.3' # Current php dev version + symfony-version: + - '4.4' # Lowest LTS + - '5.4' # Latest LTS + - '6.0' # Current major version + include: + - symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version + php-version: '8.2' + + steps: + - name: Check out code + uses: actions/checkout@v4 + + - name: Setup PHP ${{ matrix.php-version }} + uses: shivammathur/setup-php@v2 + with: + php-version: '${{ matrix.php-version }}' + tools: composer + coverage: none + env: + # Always use latest available patch for the version + update: true + + - name: Setup cache + id: cache + uses: actions/cache@v4 + with: + path: | + ~/.composer + ./vendor + # Clear the cache if composer json (as composer.lock is in the repo) has been updated + key: tests-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }} + + - name: Build + run: | + composer config minimum-stability dev \ + && composer require -W ${{ env.COMPOSER_OPTIONS }} \ + symfony/http-foundation:^${{ matrix.symfony-version }} \ + symfony/http-kernel:^${{ matrix.symfony-version }} \ + symfony/config:^${{ matrix.symfony-version }} \ + symfony/dependency-injection:^${{ matrix.symfony-version }} \ + symfony/event-dispatcher:^${{ matrix.symfony-version }} \ + symfony/routing:^${{ matrix.symfony-version }} \ + && composer update ${{ env.COMPOSER_OPTIONS }} \ + && make build + + - name: Test + run: make test-unit && make test-functional diff --git a/.github/workflows/reusable-coverage-upload-workflow.yml b/.github/workflows/reusable-coverage-upload-workflow.yml new file mode 100644 index 0000000..c397b7d --- /dev/null +++ b/.github/workflows/reusable-coverage-upload-workflow.yml @@ -0,0 +1,67 @@ +name: 'Coverage upload reusable workflow' + +on: + workflow_call: + secrets: + CODACY_PROJECT_TOKEN: + required: true + CODECOV_TOKEN: + required: true + +jobs: + fetch-info: + name: Fetch triggering workflow metadata + runs-on: ubuntu-latest + permissions: + contents: read + checks: write # For the check run creation ! + steps: + - name: 'Check run ○' + uses: yoanm/temp-reports-group-workspace/gha-attach-check-run-to-triggering-workflow@improve + with: + name: 'Fetch coverage info' + fails-on-triggering-workflow-failure: true + + - uses: yoanm/temp-reports-group-workspace/gha-fetch-workflow-metadata@improve + id: fetch-workflow-metadata + + outputs: + commit-sha: ${{ steps.fetch-workflow-metadata.outputs.commit-sha }} + run-id: ${{ steps.fetch-workflow-metadata.outputs.run-id }} + + codacy-uploader: + name: Codacy + needs: [fetch-info] + uses: yoanm/temp-reports-group-workspace/.github/workflows/codacy-upload-from-artifacts.yml@improve + permissions: + contents: read + checks: write # For the check run creation ! + secrets: + PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} + with: + artifacts-pattern: coverage-groups-* + run-id: ${{ needs.fetch-info.outputs.run-id }} + override-job-name: "Codacy title" + force-git-commit: ${{ needs.fetch-info.outputs.commit-sha }} + # force-uploader-language: ... + # force-uploader-coverage-parser: ... + # force-uploader-cli-version: ... + + codecov-uploader: + name: Codecov + needs: [fetch-info] + uses: yoanm/temp-reports-group-workspace/.github/workflows/codecov-upload-from-artifacts.yml@improve + permissions: + contents: read + checks: write # For the check run creation ! + secrets: + TOKEN: ${{ secrets.CODECOV_TOKEN }} + with: + artifacts-pattern: coverage-groups-* + run-id: ${{ needs.fetch-info.outputs.run-id }} + override-job-name: "Codecov title" + force-git-commit: ${{ needs.fetch-info.outputs.commit-sha }} + force-git-branch: ${{ needs.fetch-info.outputs.branch }} + force-gh-pr: ${{ needs.fetch-info.outputs.pr-number }} + force-uploader-build: ${{ needs.fetch-info.outputs.run-id }} + force-uploader-build-url: ${{ needs.fetch-info.outputs.run-url }} From 74fd9d97f9b897b13dc63d9ec12e02c374341786 Mon Sep 17 00:00:00 2001 From: Yoanm <4410697+yoanm@users.noreply.github.com> Date: Sun, 31 Mar 2024 15:31:08 +0200 Subject: [PATCH 2/5] Improve --- .github/workflows/reusable-CI-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-CI-workflow.yml b/.github/workflows/reusable-CI-workflow.yml index 444c14f..360e383 100644 --- a/.github/workflows/reusable-CI-workflow.yml +++ b/.github/workflows/reusable-CI-workflow.yml @@ -9,7 +9,7 @@ env: jobs: tests: - name: PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }} + name: PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }} runs-on: ubuntu-latest env: COVERAGE_TYPE: none @@ -161,7 +161,7 @@ jobs: uses: actions/dependency-review-action@v4 nightly-tests: - name: Nightly - PHP ${{ matrix.php-version }} / Symfony ${{ matrix.symfony-version }} + name: Nightly - PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }} runs-on: ubuntu-latest env: COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+' From b5b6599f0f89766fd0192a61f47f97e906307310 Mon Sep 17 00:00:00 2001 From: yoanm <4410697+yoanm@users.noreply.github.com> Date: Sun, 31 Mar 2024 16:06:33 +0200 Subject: [PATCH 3/5] Update reusable-coverage-upload-workflow.yml --- .github/workflows/reusable-coverage-upload-workflow.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/reusable-coverage-upload-workflow.yml b/.github/workflows/reusable-coverage-upload-workflow.yml index c397b7d..65e04ed 100644 --- a/.github/workflows/reusable-coverage-upload-workflow.yml +++ b/.github/workflows/reusable-coverage-upload-workflow.yml @@ -41,7 +41,6 @@ jobs: with: artifacts-pattern: coverage-groups-* run-id: ${{ needs.fetch-info.outputs.run-id }} - override-job-name: "Codacy title" force-git-commit: ${{ needs.fetch-info.outputs.commit-sha }} # force-uploader-language: ... # force-uploader-coverage-parser: ... @@ -59,7 +58,6 @@ jobs: with: artifacts-pattern: coverage-groups-* run-id: ${{ needs.fetch-info.outputs.run-id }} - override-job-name: "Codecov title" force-git-commit: ${{ needs.fetch-info.outputs.commit-sha }} force-git-branch: ${{ needs.fetch-info.outputs.branch }} force-gh-pr: ${{ needs.fetch-info.outputs.pr-number }} From 1d613d07ff2a78a5adce4d8e331dcd582fae21e6 Mon Sep 17 00:00:00 2001 From: Yoanm <4410697+yoanm@users.noreply.github.com> Date: Sun, 31 Mar 2024 16:28:18 +0200 Subject: [PATCH 4/5] Move to v0 tag --- .github/workflows/reusable-CI-workflow.yml | 4 ++-- .github/workflows/reusable-coverage-upload-workflow.yml | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/reusable-CI-workflow.yml b/.github/workflows/reusable-CI-workflow.yml index 360e383..0304636 100644 --- a/.github/workflows/reusable-CI-workflow.yml +++ b/.github/workflows/reusable-CI-workflow.yml @@ -90,7 +90,7 @@ jobs: - name: Create "unit tests" reports group if: ${{ env.COVERAGE_TYPE == 'xdebug' }} id: unit-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop + uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@v0 with: name: unit-tests format: clover @@ -104,7 +104,7 @@ jobs: - name: Create "functional tests" reports group if: ${{ env.COVERAGE_TYPE == 'xdebug' }} id: functional-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@develop + uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@v0 with: name: functional-tests format: clover diff --git a/.github/workflows/reusable-coverage-upload-workflow.yml b/.github/workflows/reusable-coverage-upload-workflow.yml index c397b7d..503f754 100644 --- a/.github/workflows/reusable-coverage-upload-workflow.yml +++ b/.github/workflows/reusable-coverage-upload-workflow.yml @@ -17,12 +17,12 @@ jobs: checks: write # For the check run creation ! steps: - name: 'Check run ○' - uses: yoanm/temp-reports-group-workspace/gha-attach-check-run-to-triggering-workflow@improve + uses: yoanm/temp-reports-group-workspace/gha-attach-check-run-to-triggering-workflow@v0 with: name: 'Fetch coverage info' fails-on-triggering-workflow-failure: true - - uses: yoanm/temp-reports-group-workspace/gha-fetch-workflow-metadata@improve + - uses: yoanm/temp-reports-group-workspace/gha-fetch-workflow-metadata@v0 id: fetch-workflow-metadata outputs: @@ -32,7 +32,7 @@ jobs: codacy-uploader: name: Codacy needs: [fetch-info] - uses: yoanm/temp-reports-group-workspace/.github/workflows/codacy-upload-from-artifacts.yml@improve + uses: yoanm/temp-reports-group-workspace/.github/workflows/codacy-upload-from-artifacts.yml@v0 permissions: contents: read checks: write # For the check run creation ! @@ -50,7 +50,7 @@ jobs: codecov-uploader: name: Codecov needs: [fetch-info] - uses: yoanm/temp-reports-group-workspace/.github/workflows/codecov-upload-from-artifacts.yml@improve + uses: yoanm/temp-reports-group-workspace/.github/workflows/codecov-upload-from-artifacts.yml@v0 permissions: contents: read checks: write # For the check run creation ! From 122bf48fdd6c08300d044e1247e78fe5afda1adb Mon Sep 17 00:00:00 2001 From: Yoanm <4410697+yoanm@users.noreply.github.com> Date: Sun, 31 Mar 2024 16:31:11 +0200 Subject: [PATCH 5/5] Fix --- .github/workflows/reusable-CI-workflow.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reusable-CI-workflow.yml b/.github/workflows/reusable-CI-workflow.yml index 0304636..f9353e4 100644 --- a/.github/workflows/reusable-CI-workflow.yml +++ b/.github/workflows/reusable-CI-workflow.yml @@ -90,7 +90,7 @@ jobs: - name: Create "unit tests" reports group if: ${{ env.COVERAGE_TYPE == 'xdebug' }} id: unit-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@v0 + uses: yoanm/temp-reports-group-workspace/gha-create@v0 with: name: unit-tests format: clover @@ -104,7 +104,7 @@ jobs: - name: Create "functional tests" reports group if: ${{ env.COVERAGE_TYPE == 'xdebug' }} id: functional-tests-coverage-group - uses: yoanm/temp-reports-group-workspace/.github/actions/create-action@v0 + uses: yoanm/temp-reports-group-workspace/gha-create@v0 with: name: functional-tests format: clover