Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "matchGlob" to "ListBucketsRequest" #259

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

otobrglez
Copy link
Contributor

Hey!

I would love to use this library for my projects. However, I found that it lacks the option to match with globbing when one wants to list objects in a bucket. I'm not sure if this PR is the right approach; however, if you can help me navigate this further, I would like to extend this codebase with this functionality.

Documentation for Google Cloud Storage - List Objects where matchGlob also lives.

Regards,

- Oto

@yoshidan yoshidan added the safe to test safe to test label Apr 30, 2024
@yoshidan
Copy link
Owner

@otobrglez

  1. Could you add the matchGlob to test .
    https://github.com/yoshidan/google-cloud-rust/actions/runs/8889195974/job/24407198542?pr=259#step:6:254

  2. Could you run cargo fix clipp and cargo fmt` to fix lint error

@yoshidan yoshidan merged commit fd66e96 into yoshidan:main May 2, 2024
4 of 6 checks passed
@yoshidan
Copy link
Owner

yoshidan commented May 2, 2024

I will fix CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants