From 84839ee8bede9f1a8d5a2aec67ce8c25e1e93e37 Mon Sep 17 00:00:00 2001 From: Badreddine Ibril Date: Tue, 13 Aug 2024 14:30:23 +0100 Subject: [PATCH 1/4] Harmony > img > Add missing "alt" --- themes/harmony/assets/add-to-cart.js | 2 +- themes/harmony/sections/main-cart.liquid | 2 +- themes/harmony/sections/main-search.liquid | 3 ++- themes/harmony/sections/main-video.liquid | 2 +- themes/harmony/sections/thankyou.liquid | 2 +- themes/harmony/snippets/product-preview.liquid | 4 ++-- themes/harmony/snippets/product-slider.liquid | 6 +++++- themes/harmony/snippets/reviews.liquid | 2 +- 8 files changed, 14 insertions(+), 9 deletions(-) diff --git a/themes/harmony/assets/add-to-cart.js b/themes/harmony/assets/add-to-cart.js index 57aa7cd0..46b63e5a 100644 --- a/themes/harmony/assets/add-to-cart.js +++ b/themes/harmony/assets/add-to-cart.js @@ -147,7 +147,7 @@ function cartTemplate(item) {
  • - ${imageUrl && ``} + ${imageUrl && `${item.productVariant.product.name}`}

    ${item.productVariant.product.name}

    diff --git a/themes/harmony/sections/main-cart.liquid b/themes/harmony/sections/main-cart.liquid index 3c814583..905053ff 100644 --- a/themes/harmony/sections/main-cart.liquid +++ b/themes/harmony/sections/main-cart.liquid @@ -34,7 +34,7 @@
    - product-name + {{ item.name  }}
    diff --git a/themes/harmony/sections/main-search.liquid b/themes/harmony/sections/main-search.liquid index 19ee9a84..98657306 100644 --- a/themes/harmony/sections/main-search.liquid +++ b/themes/harmony/sections/main-search.liquid @@ -39,7 +39,8 @@ {% else %} {{ item.name }} {% endif %}
    diff --git a/themes/harmony/sections/main-video.liquid b/themes/harmony/sections/main-video.liquid index d1a57ec9..9e9288ca 100644 --- a/themes/harmony/sections/main-video.liquid +++ b/themes/harmony/sections/main-video.liquid @@ -21,7 +21,7 @@ {% if section.settings.video_link %} {% if section.settings.video_type == 'youtube' %}
    - + YouTube Thumbnail
    diff --git a/themes/harmony/sections/thankyou.liquid b/themes/harmony/sections/thankyou.liquid index f87e8591..b2b508a9 100644 --- a/themes/harmony/sections/thankyou.liquid +++ b/themes/harmony/sections/thankyou.liquid @@ -35,7 +35,7 @@
      {% for item in order.order_variants %}
    • - + {{- item.name -}}
      {{- item.name -}}
        diff --git a/themes/harmony/snippets/product-preview.liquid b/themes/harmony/snippets/product-preview.liquid index 457319b2..8aef98a0 100644 --- a/themes/harmony/snippets/product-preview.liquid +++ b/themes/harmony/snippets/product-preview.liquid @@ -19,9 +19,9 @@ {% endif %}
      {% if item.thumbnail %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %}
    diff --git a/themes/harmony/snippets/product-slider.liquid b/themes/harmony/snippets/product-slider.liquid index 565a3bbe..6da59e1b 100644 --- a/themes/harmony/snippets/product-slider.liquid +++ b/themes/harmony/snippets/product-slider.liquid @@ -48,7 +48,11 @@
    - + {{ block.settings.product.name }} {% if block.settings.tag_text %}
    {{ block.settings.tag_text }} diff --git a/themes/harmony/snippets/reviews.liquid b/themes/harmony/snippets/reviews.liquid index 09e1adcb..d0a704b2 100644 --- a/themes/harmony/snippets/reviews.liquid +++ b/themes/harmony/snippets/reviews.liquid @@ -48,7 +48,7 @@ {{ 'reviews.upload_image' | t }}
    - + Uploaded Image
  • - ${imageUrl && ``} + ${imageUrl && `${item.productVariant.product.name}`}

    ${item.productVariant.product.name}

    diff --git a/themes/aura/sections/main-cart.liquid b/themes/aura/sections/main-cart.liquid index afeed17d..8d58ec82 100644 --- a/themes/aura/sections/main-cart.liquid +++ b/themes/aura/sections/main-cart.liquid @@ -29,7 +29,7 @@
    - product-name + {{ item.name }}
    - + Left Arrow
    {{ page.name }} diff --git a/themes/aura/sections/main-search.liquid b/themes/aura/sections/main-search.liquid index dfbd6902..afc52c1f 100644 --- a/themes/aura/sections/main-search.liquid +++ b/themes/aura/sections/main-search.liquid @@ -40,6 +40,7 @@ {{ item.name }} {% endif %}
    diff --git a/themes/aura/sections/main-video.liquid b/themes/aura/sections/main-video.liquid index d1a57ec9..7f2a5b0f 100644 --- a/themes/aura/sections/main-video.liquid +++ b/themes/aura/sections/main-video.liquid @@ -21,7 +21,7 @@ {% if section.settings.video_link %} {% if section.settings.video_type == 'youtube' %}
    - + YouTube Thumbnail
    diff --git a/themes/aura/sections/multi-column.liquid b/themes/aura/sections/multi-column.liquid index 44415465..f6e60755 100644 --- a/themes/aura/sections/multi-column.liquid +++ b/themes/aura/sections/multi-column.liquid @@ -110,7 +110,12 @@
    {% if block_setting.image %}
    - + {{ block_setting.heading }}
    {% else %}
    diff --git a/themes/aura/sections/notice-bar.liquid b/themes/aura/sections/notice-bar.liquid index 4e767ffe..0e4ef3d6 100644 --- a/themes/aura/sections/notice-bar.liquid +++ b/themes/aura/sections/notice-bar.liquid @@ -16,7 +16,7 @@ {%- if section.settings.notice_bar_show %}
    - {%- if section.settings.notice_bar_logo.src -%} {%- endif -%} + {%- if section.settings.notice_bar_logo.src -%} Notice Logo{%- endif -%}
    {{ section.settings.notice_bar_content }}
    diff --git a/themes/aura/snippets/collection-preview.liquid b/themes/aura/snippets/collection-preview.liquid index 32e8742b..9a9e4ca4 100644 --- a/themes/aura/snippets/collection-preview.liquid +++ b/themes/aura/snippets/collection-preview.liquid @@ -8,11 +8,13 @@ {{ category.name }} {% else %} {{ category.name }} {% endif %}
    diff --git a/themes/aura/snippets/product-card.liquid b/themes/aura/snippets/product-card.liquid index 3a5e43b1..bbdf8464 100644 --- a/themes/aura/snippets/product-card.liquid +++ b/themes/aura/snippets/product-card.liquid @@ -6,7 +6,7 @@ product image + alt="{{ product.name }}">
    diff --git a/themes/aura/snippets/product-preview.liquid b/themes/aura/snippets/product-preview.liquid index a2b1f025..7e3bd9c5 100644 --- a/themes/aura/snippets/product-preview.liquid +++ b/themes/aura/snippets/product-preview.liquid @@ -11,11 +11,13 @@ {{ item.name }} {% else %} {{ item.name }} {% endif %} {% if block_settings.tag_text %} diff --git a/themes/aura/snippets/product-slider.liquid b/themes/aura/snippets/product-slider.liquid index f2129eec..314bc1ef 100644 --- a/themes/aura/snippets/product-slider.liquid +++ b/themes/aura/snippets/product-slider.liquid @@ -70,6 +70,7 @@ {{ block.settings.product.name }} {% if block.settings.tag_text %}
    - + Uploaded Image
    From 6f2cb381d9d335065a1faa21f7e9aaf6c1fb1496 Mon Sep 17 00:00:00 2001 From: Badreddine Ibril Date: Tue, 13 Aug 2024 15:49:05 +0100 Subject: [PATCH 3/4] Meraky > img > Add missing "alt" --- themes/meraki/assets/add-to-cart.js | 2 +- themes/meraki/sections/featured-collections.liquid | 2 +- themes/meraki/sections/main-cart.liquid | 2 +- themes/meraki/sections/main-page.liquid | 2 +- themes/meraki/sections/main-search.liquid | 1 + themes/meraki/sections/main-video.liquid | 2 +- themes/meraki/sections/multi-column.liquid | 1 + themes/meraki/sections/notice-bar.liquid | 2 +- themes/meraki/sections/thankyou.liquid | 2 +- themes/meraki/snippets/collection-preview.liquid | 2 ++ themes/meraki/snippets/product-card.liquid | 2 +- themes/meraki/snippets/product-preview.liquid | 4 ++-- themes/meraki/snippets/product-slider.liquid | 3 ++- themes/meraki/snippets/reviews.liquid | 2 +- themes/meraki/snippets/subCategory.liquid | 2 ++ 15 files changed, 19 insertions(+), 12 deletions(-) diff --git a/themes/meraki/assets/add-to-cart.js b/themes/meraki/assets/add-to-cart.js index e41acf27..799b6223 100644 --- a/themes/meraki/assets/add-to-cart.js +++ b/themes/meraki/assets/add-to-cart.js @@ -98,7 +98,7 @@ function cartTemplate(item) { return `
  • - ${imageUrl && ``} + ${imageUrl && `${item.productVariant.product.name}`}

    ${item.productVariant.product.name}

    diff --git a/themes/meraki/sections/featured-collections.liquid b/themes/meraki/sections/featured-collections.liquid index 5c7e8c70..6c385ef7 100644 --- a/themes/meraki/sections/featured-collections.liquid +++ b/themes/meraki/sections/featured-collections.liquid @@ -38,7 +38,7 @@ {% endif %}
    {% if block.settings.category.image %} - + {{ block.settings.category.name }} {% endif %}
    diff --git a/themes/meraki/sections/main-cart.liquid b/themes/meraki/sections/main-cart.liquid index 618b18b7..581c1d3b 100644 --- a/themes/meraki/sections/main-cart.liquid +++ b/themes/meraki/sections/main-cart.liquid @@ -21,7 +21,7 @@
    - product-name + {{ item.name }}
    diff --git a/themes/meraki/sections/main-page.liquid b/themes/meraki/sections/main-page.liquid index 44431f6e..b396e611 100644 --- a/themes/meraki/sections/main-page.liquid +++ b/themes/meraki/sections/main-page.liquid @@ -7,7 +7,7 @@ {{ 'snippets.collection-listing.home' | t }}
    - + Left arrow
    {{ page.name }} diff --git a/themes/meraki/sections/main-search.liquid b/themes/meraki/sections/main-search.liquid index 1c2b234b..514c450f 100644 --- a/themes/meraki/sections/main-search.liquid +++ b/themes/meraki/sections/main-search.liquid @@ -44,6 +44,7 @@ {{ item.name }} {% endif %}
    diff --git a/themes/meraki/sections/main-video.liquid b/themes/meraki/sections/main-video.liquid index cee01b6a..0d2129e7 100644 --- a/themes/meraki/sections/main-video.liquid +++ b/themes/meraki/sections/main-video.liquid @@ -21,7 +21,7 @@ {% if section.settings.video_link %} {% if section.settings.video_type == 'youtube' %}
    - + YouTube Thumbnail
    diff --git a/themes/meraki/sections/multi-column.liquid b/themes/meraki/sections/multi-column.liquid index 0b779353..db5d140b 100644 --- a/themes/meraki/sections/multi-column.liquid +++ b/themes/meraki/sections/multi-column.liquid @@ -135,6 +135,7 @@ class='column-image' src='{{ block_setting.image.src }}' loading='lazy' + alt='{{ block_setting.heading }}' >
    {% else %} diff --git a/themes/meraki/sections/notice-bar.liquid b/themes/meraki/sections/notice-bar.liquid index 19261f8f..10e9387c 100644 --- a/themes/meraki/sections/notice-bar.liquid +++ b/themes/meraki/sections/notice-bar.liquid @@ -16,7 +16,7 @@ {%- if section.settings.notice_bar_show %}
    - {%- if section.settings.notice_bar_logo.src -%} {%- endif -%} + {%- if section.settings.notice_bar_logo.src -%} Notice logo{%- endif -%}
    {{ section.settings.notice_bar_content }}
    diff --git a/themes/meraki/sections/thankyou.liquid b/themes/meraki/sections/thankyou.liquid index 9d92616d..2660839e 100644 --- a/themes/meraki/sections/thankyou.liquid +++ b/themes/meraki/sections/thankyou.liquid @@ -34,7 +34,7 @@
      {% for item in order.order_variants %}
    • - + {{- item.name -}}
      {{- item.name -}}
        diff --git a/themes/meraki/snippets/collection-preview.liquid b/themes/meraki/snippets/collection-preview.liquid index 68c4d5f1..0dbda4ac 100644 --- a/themes/meraki/snippets/collection-preview.liquid +++ b/themes/meraki/snippets/collection-preview.liquid @@ -7,11 +7,13 @@ {{ category.name }} {% else %} {{ category.name }} {% endif %}
        diff --git a/themes/meraki/snippets/product-card.liquid b/themes/meraki/snippets/product-card.liquid index 5b067106..65f3c80e 100644 --- a/themes/meraki/snippets/product-card.liquid +++ b/themes/meraki/snippets/product-card.liquid @@ -5,7 +5,7 @@ product image + alt="{{ product.name }}">
        diff --git a/themes/meraki/snippets/product-preview.liquid b/themes/meraki/snippets/product-preview.liquid index 8e36b5f7..66890d28 100644 --- a/themes/meraki/snippets/product-preview.liquid +++ b/themes/meraki/snippets/product-preview.liquid @@ -16,9 +16,9 @@
        {% if item.thumbnail %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %}
      diff --git a/themes/meraki/snippets/product-slider.liquid b/themes/meraki/snippets/product-slider.liquid index 1f535138..7ebbb429 100644 --- a/themes/meraki/snippets/product-slider.liquid +++ b/themes/meraki/snippets/product-slider.liquid @@ -55,7 +55,8 @@ + alt='{{ block.settings.product.name }}' + > {% if block.settings.tag_text %}
      - + Uploaded image
      From f98f3bed846852306e0957809de1a8693ab474b4 Mon Sep 17 00:00:00 2001 From: Badreddine Ibril Date: Tue, 13 Aug 2024 16:00:20 +0100 Subject: [PATCH 4/4] Self review --- themes/aura/sections/main-page.liquid | 2 +- themes/aura/sections/main-video.liquid | 2 +- themes/aura/sections/notice-bar.liquid | 2 +- themes/aura/snippets/reviews.liquid | 2 +- themes/harmony/sections/main-video.liquid | 2 +- themes/harmony/sections/multi-column.liquid | 1 + themes/harmony/snippets/collection-preview.liquid | 2 ++ themes/harmony/snippets/product-card.liquid | 2 +- themes/harmony/snippets/reviews.liquid | 2 +- themes/harmony/snippets/subCategory.liquid | 2 ++ themes/meraki/sections/main-video.liquid | 2 +- 11 files changed, 13 insertions(+), 8 deletions(-) diff --git a/themes/aura/sections/main-page.liquid b/themes/aura/sections/main-page.liquid index aab10a96..fadff15f 100644 --- a/themes/aura/sections/main-page.liquid +++ b/themes/aura/sections/main-page.liquid @@ -7,7 +7,7 @@ {{ 'snippets.collection-listing.home' | t }}
    - Left Arrow + Left arrow
    {{ page.name }} diff --git a/themes/aura/sections/main-video.liquid b/themes/aura/sections/main-video.liquid index 7f2a5b0f..8edea8ef 100644 --- a/themes/aura/sections/main-video.liquid +++ b/themes/aura/sections/main-video.liquid @@ -21,7 +21,7 @@ {% if section.settings.video_link %} {% if section.settings.video_type == 'youtube' %}
    - YouTube Thumbnail + YouTube thumbnail
    diff --git a/themes/aura/sections/notice-bar.liquid b/themes/aura/sections/notice-bar.liquid index 0e4ef3d6..a073e393 100644 --- a/themes/aura/sections/notice-bar.liquid +++ b/themes/aura/sections/notice-bar.liquid @@ -16,7 +16,7 @@ {%- if section.settings.notice_bar_show %}
    - {%- if section.settings.notice_bar_logo.src -%} Notice Logo{%- endif -%} + {%- if section.settings.notice_bar_logo.src -%} Notice logo{%- endif -%}
    {{ section.settings.notice_bar_content }}
    diff --git a/themes/aura/snippets/reviews.liquid b/themes/aura/snippets/reviews.liquid index f29d25a3..b83125ed 100644 --- a/themes/aura/snippets/reviews.liquid +++ b/themes/aura/snippets/reviews.liquid @@ -49,7 +49,7 @@ {{ 'reviews.upload_image' | t }}
    - Uploaded Image + Uploaded image
    {% else %} diff --git a/themes/harmony/snippets/collection-preview.liquid b/themes/harmony/snippets/collection-preview.liquid index 32e8742b..9a9e4ca4 100644 --- a/themes/harmony/snippets/collection-preview.liquid +++ b/themes/harmony/snippets/collection-preview.liquid @@ -8,11 +8,13 @@ {{ category.name }} {% else %} {{ category.name }} {% endif %}
    diff --git a/themes/harmony/snippets/product-card.liquid b/themes/harmony/snippets/product-card.liquid index 02f59dee..fe805a77 100644 --- a/themes/harmony/snippets/product-card.liquid +++ b/themes/harmony/snippets/product-card.liquid @@ -5,7 +5,7 @@ product image
    diff --git a/themes/harmony/snippets/reviews.liquid b/themes/harmony/snippets/reviews.liquid index d0a704b2..289ca12f 100644 --- a/themes/harmony/snippets/reviews.liquid +++ b/themes/harmony/snippets/reviews.liquid @@ -48,7 +48,7 @@ {{ 'reviews.upload_image' | t }}
    - Uploaded Image + Uploaded image
    diff --git a/themes/meraki/sections/main-video.liquid b/themes/meraki/sections/main-video.liquid index 0d2129e7..6f5657d6 100644 --- a/themes/meraki/sections/main-video.liquid +++ b/themes/meraki/sections/main-video.liquid @@ -21,7 +21,7 @@ {% if section.settings.video_link %} {% if section.settings.video_type == 'youtube' %}
    - YouTube Thumbnail + YouTube thumbnail