Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw error when attempting to $unset a field that don't exist #760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

throw error when attempting to $unset a field that don't exist #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mongo_connector/doc_managers/doc_manager_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,11 @@ def _unset_field(doc, to_unset):
where[index_or_key] = None
else:
# Unset field removes it entirely.
del where[index_or_key]
if where and where.get(index_or_key):
del where[index_or_key]
else:
del doc[to_unset]
if doc and doc.get(to_unset):
del doc[to_unset]
except (KeyError, IndexError, ValueError):
source_version = get_mininum_mongodb_version()
if source_version is None or source_version.at_least(2, 6):
Expand Down