Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Python 3.6 and MongoDB 3.6. Ref #767. #834

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run tests on Python 3.6 and MongoDB 3.6. Ref #767. #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a02914c
Run tests on Python 3.6 and MongoDB 3.6. Ref #767.
Oct 15, 2018
7dca454
Declare support for MongoDB 3.6. Fixes #767.
Oct 15, 2018
40ae2b7
FIX #836 Remove $v entry in update documents for mongo doc manager
Dec 4, 2018
654442c
Merge branch 'bugfix/836-remove-v' into feature/mongodb-3.6-tests
Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:
env: MONGODB=3.4.17
- python: &latest_py3 3.7
env: MONGODB=3.4.17
- python: *latest_py3
env: MONGODB=3.6.8
- stage: deploy
if: tag IS present
python: *latest_py3
Expand Down
2 changes: 2 additions & 0 deletions mongo_connector/doc_managers/mongo_doc_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ def update(self, document_id, update_spec, namespace, timestamp):
)

no_obj_error = "No matching object found"
if "$v" in update_spec:
update_spec.pop("$v")
updated = self.mongo[db].command(
SON(
[
Expand Down