Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[setup] return 0 as number of cpus on windows to disable parallel build #2441

Merged
merged 2 commits into from
Feb 5, 2020
Merged

[setup] return 0 as number of cpus on windows to disable parallel build #2441

merged 2 commits into from
Feb 5, 2020

Conversation

Xarthisius
Copy link
Member

Minor tweak to PR #2438 , instead of returning None in _get_cpu_count, return 0. Now it matches default value of cythonize and it's more clear in build_extensions.

@ngoldbaum
Copy link
Member

I think you can remove the multiprocessing import too.

munkm
munkm approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the function @Xarthisius.

@matthewturk matthewturk merged commit 1d1276d into yt-project:yt-4.0 Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkm munkm munkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xarthisius @ngoldbaum @munkm @matthewturk