Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting #2450 (test job updates) to yt-4.0 #2513

Merged
merged 15 commits into from
Apr 17, 2020

Conversation

matthewturk
Copy link
Member

I did my best in porting #2450 to yt-4.0. Let's see if it succeeds! There may be additional bits I missed that were not explicitly included in 2450, however.

@matthewturk matthewturk added the tests: running tests Issues with the test setup label Apr 1, 2020
@matthewturk matthewturk requested review from Xarthisius and munkm April 1, 2020 15:25
.travis.yml Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
@matthewturk
Copy link
Member Author

Looks like some errors I need to deal with. Will do that and push a new set of commits with the updates.

@matthewturk
Copy link
Member Author

I removed NUMPY_VERSION from appveyor.yml as it's not in master, and seems to break appveyor.

@matthewturk
Copy link
Member Author

OK, so, it's now failing with 31 actual errors, which I believe are all real. At this point it seems that we're stuck with checking in new answers eventually, so let me check a few things out before proceeding.

@matthewturk
Copy link
Member Author

Basically, where this is at: the test differences are real but not significant (pixel-level shifts), but I'm reluctant to check in yet another set of new tests until we figure out how to do so without bloating the repo too much. I'm hoping this will be resolved through something like git-lfs, but until this is discussed on the yt-dev mailing list I'm not sure.

@matthewturk matthewturk added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Apr 15, 2020
@matthewturk
Copy link
Member Author

So the plan now is to see the current travis test failures, validate the "answer results," and if they are valid, to commit them to https://github.com/yt-project/answer-store/ in the branch yt-4.0 and re-trigger a build here to make sure they work.

@matthewturk
Copy link
Member Author

@Xarthisius I'm not sure I totally get the codecov results, but I think maybe it's because we're not testing the same number of versions? If that's indeed the case, is it OK if we merge this?

@Xarthisius
Copy link
Member

@Xarthisius I'm not sure I totally get the codecov results, but I think maybe it's because we're not testing the same number of versions? If that's indeed the case, is it OK if we merge this?

The missing coverage is from not running answer tests on jenkins. Yes, it's ok to merge.

@Xarthisius Xarthisius merged commit fecf079 into yt-project:yt-4.0 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants