-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting #2450 (test job updates) to yt-4.0 #2513
Porting #2450 (test job updates) to yt-4.0 #2513
Conversation
Looks like some errors I need to deal with. Will do that and push a new set of commits with the updates. |
I removed |
… as the 3rd argument of np.linspace (npoints)
OK, so, it's now failing with 31 actual errors, which I believe are all real. At this point it seems that we're stuck with checking in new answers eventually, so let me check a few things out before proceeding. |
Hash is 5172707
Basically, where this is at: the test differences are real but not significant (pixel-level shifts), but I'm reluctant to check in yet another set of new tests until we figure out how to do so without bloating the repo too much. I'm hoping this will be resolved through something like |
This reverts commit c9ae3ae.
So the plan now is to see the current travis test failures, validate the "answer results," and if they are valid, to commit them to https://github.com/yt-project/answer-store/ in the branch yt-4.0 and re-trigger a build here to make sure they work. |
@Xarthisius I'm not sure I totally get the codecov results, but I think maybe it's because we're not testing the same number of versions? If that's indeed the case, is it OK if we merge this? |
The missing coverage is from not running answer tests on jenkins. Yes, it's ok to merge. |
I did my best in porting #2450 to yt-4.0. Let's see if it succeeds! There may be additional bits I missed that were not explicitly included in 2450, however.