Put answers in a subrepo #2545
Merged
Put answers in a subrepo #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
added
tests: running tests
|
@munkm suggests this go on 4.0 -- I will leave this open and issue a new PR too. |
Xarthisius
approved these changes
Apr 15, 2020
munkm
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts our
answer-storedirectory in a submodule. Unless someone clones--recursive, by default they won't get the full history of the answer tests.One open question I have is if I can or should do anything to suggest a depth of the clone; from what I can tell, specifying
--depthin thegit submodule addcommand wouldn't change anything for folks cloning the repo, but I may be misreading.Travis should clone by default all the submodules, so let's see how it goes...