Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yt-4.0] check for bbox before reverting to all_data #2634

Merged
merged 2 commits into from
Jun 23, 2020
Merged

[yt-4.0] check for bbox before reverting to all_data #2634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc5f18
added domain_override check to the all_data_check
AshKelly Jun 12, 2020
5f12c13
fixed bad access
AshKelly Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion yt/geometry/selection_routines.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,9 @@ cdef class RegionSelector(SelectorObject):
cdef np.float64_t[:] DRE = _ensure_code(dobj.ds.domain_right_edge)
le_all = (np.array(LE) == _ensure_code(dobj.ds.domain_left_edge)).all()
re_all = (np.array(RE) == _ensure_code(dobj.ds.domain_right_edge)).all()
if le_all and re_all:
# If we have a bounding box, then we should *not* revert to all data
domain_override = getattr(dobj.ds, '_domain_override', False)
if le_all and re_all and not domain_override:
self.is_all_data = True
else:
self.is_all_data = False
Expand Down