Don't allow edges to extend beyond domain for SPH region sources. #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xarthisius
approved these changes
Jun 16, 2020
munkm
approved these changes
Jun 16, 2020
cphyc
approved these changes
Jun 18, 2020
|
I had to update this (I am sorry!) because I realized that when the data is periodic, we want the region to go as it was, over the boundaries. @cphyc @Xarthisius @munkm another quick look? |
munkm
approved these changes
Jun 18, 2020
|
Sidenote, I can't wait to test this against my own (amrvac) datasets. I've been using workarounds to avoid this issue, and never took the time to report or inspect it. Thanks a lot ! |
chummels
approved these changes
Jun 18, 2020
|
Those images were generated with this change.
…On Thu, Jun 18, 2020 at 3:20 PM Cameron Hummels ***@***.***> wrote:
@chummels approved this pull request.
This looks good. It would be cool to see what different behavior this produces for the TipsyGalaxy answer test projections, which probably would address the concerns I brought up in my review of the answer test results for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This showed up when generating the gallery using the
TipsyGalaxydataset. What would happen is that if you set the width to(1.0, 'unitary')it would extend the plot beyond the edge of the domain, which would then create a region that went beyond the edge of the domain, and then break because the dataset wasn't periodic. This prevents that from happening.