Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test dependencies #2735

Merged
merged 14 commits into from
Jul 20, 2020
Merged

Update test dependencies #2735

merged 14 commits into from
Jul 20, 2020

Conversation

Xarthisius
Copy link
Member

I'm bumping a few dependencies to minimal versions that have binary wheels for py38 in order to avoid building them each time. In particular pandas takes some time to build.

@Xarthisius Xarthisius added infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup labels Jul 10, 2020
matthewturk
matthewturk reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlap change seems good to me.

@Xarthisius
Copy link
Member Author

@yt-fido test this please

@matthewturk
Copy link
Member

this looks good, modulo fido's approval

munkm
munkm reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good, but shouldn't line 24 be unyt==2.7.2 from PR #2705?

munkm
munkm approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see it's from c8ea5b6. Sorry about that!

@Xarthisius
Copy link
Member Author

@yt-fido test this please

neutrinoceros
neutrinoceros reviewed Jul 18, 2020
View reviewed changes
tests/test_requirements.txt
fastcache==1.0.2
glueviz==0.13.3
h5py==2.10.0
ipython==7.1.1
matplotlib==3.1.3
matplotlib==3.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's alright but maybe we should future proof this and use their bug fixes releases as soon as they come out ?

Suggested change
matplotlib==3.3.0
matplotlib~=3.3

tests/test_requirements.txt Show resolved Hide resolved
@Xarthisius Xarthisius force-pushed the update_deps branch 4 times, most recently from 0dfefca to e249fbc Compare July 19, 2020 15:47
@matthewturk
Copy link
Member

This ready to go?

@Xarthisius
Copy link
Member Author

This ready to go?

Yeah, as soon as appveyor finishes. Docs are failing for some reason, but I've seen it on other PRs too.

Xarthisius added a commit to yt-project/answer-store that referenced this pull request Jul 19, 2020
@Xarthisius
Update related to yt-project/yt#2735
414c76d 
More details about the test failure can be found at the URL: http://use.yt/upload/84bbfca3
answer(s) for failed test at URL: http://use.yt/upload/bc305b8c
@neutrinoceros neutrinoceros mentioned this pull request Jul 19, 2020
Merged
@Xarthisius Xarthisius mentioned this pull request Jul 20, 2020
Closed
@matthewturk
Copy link
Member

Once this passes tests, I think we should merge! Then we'll be back to green!

@Xarthisius
Copy link
Member Author

Xarthisius commented Jul 20, 2020 •
edited
Loading

@neutrinoceros PTAL at eb56722 That config option needs to be set before importing startup_tasks. Otherwise our subcommands for yt are broken, which is what's causing our docs to hang currently on master. I tried to use isort's "action comments", but every time I run isort the line setting the __command_line is getting moved after imports. Can you figure out how to do that properly?

@neutrinoceros
Copy link
Member

@Xarthisius I think you might just need to update isort: version 5.1.4 seems to work correctly with the action comments (though the file isn't skipped, at least if I target it specifically).

@cphyc cphyc mentioned this pull request Jul 20, 2020
Merged
8 tasks
neutrinoceros
neutrinoceros reviewed Jul 20, 2020
View reviewed changes
yt/utilities/command_line.py
@@ -1,3 +1,4 @@
# isort: skip-file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that it'd be easier to manage if instead of this comment, the file was added to isort's ignore list in setup.cfg, but it shouldn't hold this PR back.

@matthewturk , can you do it in #2756 ?

@Xarthisius Xarthisius merged commit f9371fb into yt-project:master Jul 20, 2020
@Xarthisius Xarthisius deleted the update_deps branch July 20, 2020 15:00
munkm added a commit to yt-project/answer-store that referenced this pull request Jul 24, 2020
@munkm
Merge pull request #6 from yt-project/yt_pr2735
95992e6 
Update related to yt-project/yt#2735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

@munkm munkm munkm approved these changes

@cphyc cphyc cphyc approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xarthisius @matthewturk @neutrinoceros @cphyc @munkm