Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future proofing: add a scheduled job with dev versions of core deps #3376

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Future proofing: add a scheduled job with dev versions of core deps #3376

merged 1 commit into from
Jul 9, 2021

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jun 23, 2021 •
edited
Loading

PR Summary

This adds a workflow to run essential tests against Python 3.10, with dev versions of numpy and matplotlib. The goal is to buy ourselves more time to fix issues (or reporting upstream) before it's too late.

The job is setup to be triggered at least once a day, as well as on every push to the main branch.
GH actions currently do not support a way to signal this properly (yet),
so I won't make it trigger on PRs

This is heavily inspired from a similar workflow in the pandas repo.

While I'm at it I'm updating the triggers for regular CI workflows so we can save a few hours of CPU time by skipping tests on PRs that only touch documentation.

@neutrinoceros neutrinoceros added infrastructure Related to CI, versioning, websites, organizational issues, etc proposal Proposals for enhancements, changes, etc labels Jun 23, 2021
@neutrinoceros
Copy link
Member Author

Ok so I got the workflow to run. It's failing because of a newly revealed api breakage from matplotlib, which is the whole purpose of this first line of defense. To avoid polluting everyone's PRs with :x:, I changed the triggers: this workflow will not trigger on PRs but will run on the main branch upon merge, and 4 times a day even when nothing else happens.
The status of the workflow will be displayed in the README for convenience as
https://github.com/yt-project/yt/actions/workflows/bleeding-edge.yaml/badge.svg

@neutrinoceros neutrinoceros marked this pull request as ready for review June 23, 2021 22:56
@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jun 25, 2021 •
edited
Loading

For reference I'm working on the breaking change that was checked-in in matplotlib recently. I'll probably end up reporting upstream and hopefully it can be fixed before matplotlib 3.5 is actually released.

edit: the faulty commit in matplotlib was 146856b03e85aa4b1becdd89fe1628f98fed2a05, I'll file a proper report upstream later

@neutrinoceros neutrinoceros marked this pull request as draft June 25, 2021 10:27
@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jun 25, 2021 •
edited
Loading

marking this as draft for now because it removes the hard pinning to forbid matplotlib 3.5, and this doesn't look like a wise thing to do at the moment.

@neutrinoceros
Copy link
Member Author

reported upstream matplotlib/matplotlib#20520

This was referenced Jun 26, 2021
Closed
Merged
@neutrinoceros neutrinoceros changed the title CI: add a scheduled job with dev versions of core deps future proofing: add a scheduled job with dev versions of core deps Jun 28, 2021
@neutrinoceros neutrinoceros changed the title future proofing: add a scheduled job with dev versions of core deps Future proofing: add a scheduled job with dev versions of core deps Jun 28, 2021
@neutrinoceros neutrinoceros force-pushed the dev_ci branch 3 times, most recently from d220f4b to 7114da2 Compare June 29, 2021 14:25
@neutrinoceros neutrinoceros mentioned this pull request Jun 29, 2021
Merged
@neutrinoceros
Copy link
Member Author

now that the release is out, I believe this is safe to merge as is.

@neutrinoceros neutrinoceros marked this pull request as ready for review July 6, 2021 16:08
@neutrinoceros
Copy link
Member Author

The problem with matplotlib has allegedly been fixed upstream 🎉
I'm going to rerun this job here to check that, and see how we're doing now. Moving to draft in the mean time.

@neutrinoceros neutrinoceros marked this pull request as draft July 8, 2021 07:47
@neutrinoceros
Copy link
Member Author

Great news, the job passed (https://github.com/yt-project/yt/actions/runs/1010839948)

@neutrinoceros neutrinoceros added the tests: running tests Issues with the test setup label Jul 8, 2021
@neutrinoceros neutrinoceros requested a review from Xarthisius July 8, 2021 08:38
@neutrinoceros neutrinoceros marked this pull request as ready for review July 8, 2021 08:38
cphyc
cphyc approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that seems like a nice addition :)

matthewturk
matthewturk approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be a good addition.

@neutrinoceros neutrinoceros merged commit 419a8eb into yt-project:main Jul 9, 2021
@neutrinoceros neutrinoceros deleted the dev_ci branch July 9, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

@matthewturk matthewturk matthewturk approved these changes

@Xarthisius Xarthisius Awaiting requested review from Xarthisius

Assignees
No one assigned
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc proposal Proposals for enhancements, changes, etc tests: running tests Issues with the test setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neutrinoceros @matthewturk @Xarthisius @cphyc