Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.6 #100

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Conversation

brittonsmith
Copy link
Member

This drops support for python 3.6 following the same move in yt. I've also updated python versions and caches.

setup.cfg Outdated
@@ -39,7 +39,7 @@ install_requires =
h5py>=3.1.0,<4.0.0
more_itertools>=8.4
yt>=4.0.1
python_requires = >=3.6
python_requires = >=3.7,<3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference, the reason why we're currently pinning Python < 3.12 in yt is because the distutils module will be removed from the standard library. I suspect it would be pretty easy to migrate out of using it in yt_astro, but maybe not. See yt-project/yt#3384

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I thought I would just copy it here to be consistent.

Something seems to have broken with building the dependencies unrelated to this. I'll see if I can figure it out.

@brittonsmith
Copy link
Member Author

I'm not sure what's up with these compile errors. We seem to no longer be able to compile rockstar-galaxies on circle-ci.

@neutrinoceros
Copy link
Member

any reason to keep this open @brittonsmith ?

@brittonsmith
Copy link
Member Author

I suppose not, although I am distressed by the fact that the ci can no longer build the dependencies. Things will only continue to work for as long as the cached dependencies stick around. An alternative could be to port the ci to github actions and hope this issue is identified/resolved as a byproduct.

@brittonsmith
Copy link
Member Author

Closing this, but note left in Issue #102.

@brittonsmith brittonsmith merged commit 29dfec6 into yt-project:main Nov 3, 2021
@brittonsmith brittonsmith deleted the drop36 branch November 3, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants