Skip to content

Commit

Permalink
[NHK] Use new API URL
Browse files Browse the repository at this point in the history
  • Loading branch information
@dirkf
dirkf committed Jun 15, 2022
1 parent 11665dd commit 8a158a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion youtube_dl/extractor/nhk.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@


class NhkBaseIE(InfoExtractor):
_API_URL_TEMPLATE = 'https://api.nhk.or.jp/nhkworld/%sod%slist/v7a/%s/%s/%s/all%s.json'
_API_URL_TEMPLATE = 'https://nwapi.nhk.jp/nhkworld/%sod%slist/v7b/%s/%s/%s/all%s.json'
_BASE_URL_REGEX = r'https?://www3\.nhk\.or\.jp/nhkworld/(?P<lang>[a-z]{2})/ondemand'
_TYPE_REGEX = r'/(?P<type>video|audio)/'

Expand Down

3 comments on commit 8a158a9

@ke352802081770314
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. it works.
I would really appreciate a release with the fixed stuff at some point. to the average user it is confusing that issues are closed as fixed when the version that claims to be current still contains the broken stuff.
(I did a zip -F bin/youtube-dl --out bin/youtube-dl.zip; unzip -x bin/youtube-dl.zip youtube_dl/extractor/nhk.py; vi youtube_dl/extractor/nhk.py; zip -f bin/youtube-dl.zip youtube_dl/extractor/nhk.py and now call it as python ~/bin/youtube-dl.zip every time.)

@NWJ9PB
Copy link

@NWJ9PB NWJ9PB commented on 8a158a9 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can anyone can confirm that this still works?

@ke352802081770314
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to report, meanwhile I switched to yt-dlp which has NhkVod working without any fiddling, it seems the reason was that this youtube-dl extractor stopped working again in December 2023 (or earlier and then I noticed it).

Please sign in to comment.