Made some refactor, fix some bugs #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug that confused me: if I DO NOT use the colorful log, then some of the tail logs won't be displayed, anyone could help me?
Seperate the big file to some small files, it maybe easier to maintain. *** I don't know why MCDVTTextStorage must use method_exchangeImplementations to hook the original method, not like others.
*** I don't known why this version's Log filter is so bad.
…should not remove the pattern object in -[MCLog searchFieldDidEndEditing:] but in -[MCLogIDEConsoleArea _shouldAppendItem:] when searchFile.text is empty
I found the cause of Issue yuhua-chen#39: In last version of yuhua-chen/MCLog, use GCD and buffer_queue to wait the coming unfinished log content, so there is a risk: we operate the unprocessedOutputInfo in two threads. In some situation, if we set value to unprocessedBuffer ( the code actually is " [unprocessedBuffer release]; unprocessedBuffer = newVal;" ), if method "outputForStandardOutput:"(thread 1), after the call of "[unprocessedBuffer release];" thread 2(buffer_queue) go into MCOutputUnprocessedBuffer and get the value of unprocessedBuffer, there would be EXC_BAD_ACCESS.
yuhua-chen
added a commit
that referenced
this pull request
Jan 26, 2016
Made some refactor, fix some bugs
|
thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
I found out and fixed the bug that caused the serious performance of filtering logs.
Please review and merge my PR, thanks :)
Alex