Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple throws + IP support #413

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix for multiple throws + IP support #413

wants to merge 7 commits into from

Conversation

bamo
Copy link

@bamo bamo commented Jun 14, 2016

Hi,

So there was an issue where if multiple @throws are included in a @method block, only the last one is reflected in the generated docs. This is not a good system, because a method can certainly throw multiple different types of exceptions. This issue was both a parser and a template issue. In the parser, the throws digester just pointed to the return digester (which can only handle one instance). So, I made the throws an array rather than one value, and created a new digester for throws (based largely on the return one). In the templates, I simply made the throws a

    with
  • for each @throws (like @param).

    The second change is that you can create a server that is not simply localhost. You can specify yuidoc --server IP:PORT. This isn't required, though, and it retains the capability of the existing syntax (yuidoc --server PORT), in which case the IP defaults to localhost. So, this only adds a potentially useful capability while maintaining backwards compatibility.

    Thanks!

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@bamo
Copy link
Author

bamo commented Jun 14, 2016

RIP let me first fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants