From def831646e8afb8fb958db8fe62cb90565606afd Mon Sep 17 00:00:00 2001 From: Tomohiro Kumagai Date: Wed, 25 Oct 2023 02:19:40 +0900 Subject: [PATCH 1/5] =?UTF-8?q?Delegate=20=E8=AA=B2=E9=A1=8C=E3=81=AE?= =?UTF-8?q?=E7=99=BB=E5=A0=B4=E4=BD=8D=E7=BD=AE=E3=82=92=E5=85=83=E3=81=AB?= =?UTF-8?q?=E6=88=BB=E3=81=97=E3=81=BE=E3=81=99=E3=80=82?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Delegate の登場順番は悩ましいところですが、非同期処理の課題を束ね、複数の方法を比べながら学習を進められることに重きを置くことにしました。 Revert "Merge pull request #27 from yumemi-inc/feature/move_delegate_section" This reverts commit d2d07f7a148434f87f04c537e36066bb856d892d, reversing changes made to 0c5dc570fec4111c588737ef9b7626cd30469da4. --- Documentation/Delegate.md | 2 +- README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/Delegate.md b/Documentation/Delegate.md index 455943a..e6b8e5e 100644 --- a/Documentation/Delegate.md +++ b/Documentation/Delegate.md @@ -14,7 +14,7 @@ UITableViewDelegateはProtocolで、Cellが選択されたときの関数が宣 UITableViewはUITableViewDelegateの実装クラスを保持し、必要な時にDelegateの関数を呼び出します。 ## 課題 -- Delegateパターンを使い、APIから天気予報を受け取る +- Delegateパターンを使い、同期APIから天気予報を受け取る - ViewControllerに`deinit`を実装し、ログを出力するようにしておく - ViewControllerを閉じた時に`deinit`が呼ばれることを確認する diff --git a/README.md b/README.md index 6fc22a9..9d18c98 100644 --- a/README.md +++ b/README.md @@ -42,14 +42,14 @@ Session1がレビュー待ちの場合... # Session 1. [AutoLayout](Documentation/AutoLayout.md) 1. [API](Documentation/API.md) -1. [Lifecycle](Documentation/VC_Lifecycle.md) -1. [Delegate](Documentation/Delegate.md) 1. [Error](Documentation/Error.md) 1. [Json](Documentation/Json.md) 1. [Codable](Documentation/Codable.md) +1. [Lifecycle](Documentation/VC_Lifecycle.md) 1. [NotificationCenter](Documentation/NotificationCenter.md) 1. [UnitTest](Documentation/UnitTest.md) 1. [ThreadBlock](Documentation/ThreadBlock.md) +1. [Delegate](Documentation/Delegate.md) 1. [Closure](Documentation/Closure.md) 1. [Concurrency](Documentation/Concurrency.md) 1. UIKit From 74fc657302cf958bec3c827ac5dd958698a12941 Mon Sep 17 00:00:00 2001 From: Tomohiro Kumagai Date: Wed, 25 Oct 2023 02:28:52 +0900 Subject: [PATCH 2/5] =?UTF-8?q?Closure=20=E3=81=AE=E8=AA=B2=E9=A1=8C?= =?UTF-8?q?=E5=90=8D=E3=82=92=E3=80=81=E9=9D=9E=E5=90=8C=E6=9C=9F=E5=87=A6?= =?UTF-8?q?=E7=90=86=E3=81=AE=E8=A6=B3=E7=82=B9=E3=81=8B=E3=82=89=20Callba?= =?UTF-8?q?ck=20=E3=81=AB=E5=A4=89=E6=9B=B4=E3=81=97=E3=81=BE=E3=81=99?= =?UTF-8?q?=E3=80=82?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Documentation/{Closure.md => Callback.md} | 0 README.md | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename Documentation/{Closure.md => Callback.md} (100%) diff --git a/Documentation/Closure.md b/Documentation/Callback.md similarity index 100% rename from Documentation/Closure.md rename to Documentation/Callback.md diff --git a/README.md b/README.md index 9d18c98..6815d60 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,7 @@ Session1がレビュー待ちの場合... 1. [UnitTest](Documentation/UnitTest.md) 1. [ThreadBlock](Documentation/ThreadBlock.md) 1. [Delegate](Documentation/Delegate.md) -1. [Closure](Documentation/Closure.md) +1. [Callback](Documentation/Callback.md) 1. [Concurrency](Documentation/Concurrency.md) 1. UIKit 1. [UITableView](Documentation/UITableView.md) From b3d8be9f5b0ce2dc5bf7085e7f1ba45cd90e5353 Mon Sep 17 00:00:00 2001 From: Tomohiro Kumagai Date: Wed, 25 Oct 2023 03:01:17 +0900 Subject: [PATCH 3/5] =?UTF-8?q?=E8=AA=B2=E9=A1=8C=E3=82=92=E3=82=B0?= =?UTF-8?q?=E3=83=AB=E3=83=BC=E3=83=97=E5=88=86=E3=81=91=E3=81=97=E3=80=81?= =?UTF-8?q?=E3=81=9D=E3=82=8C=E3=81=9E=E3=82=8C=E3=81=AE=E7=95=AA=E5=8F=B7?= =?UTF-8?q?=E3=82=92=E6=95=B4=E6=95=B0=E3=81=A7=E3=81=AE=E9=80=9A=E3=81=97?= =?UTF-8?q?=E7=95=AA=E5=8F=B7=E3=81=A8=E3=81=97=E3=81=BE=E3=81=97=E3=81=9F?= =?UTF-8?q?=E3=80=82?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 49 +++++++++++++++++++++++++++++++++---------------- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 6815d60..d8375a7 100644 --- a/README.md +++ b/README.md @@ -40,22 +40,39 @@ Session1がレビュー待ちの場合... 1. `session/1`のマージ後、`session/2`を`main`でrebaseする # Session -1. [AutoLayout](Documentation/AutoLayout.md) -1. [API](Documentation/API.md) -1. [Error](Documentation/Error.md) -1. [Json](Documentation/Json.md) -1. [Codable](Documentation/Codable.md) -1. [Lifecycle](Documentation/VC_Lifecycle.md) -1. [NotificationCenter](Documentation/NotificationCenter.md) -1. [UnitTest](Documentation/UnitTest.md) -1. [ThreadBlock](Documentation/ThreadBlock.md) -1. [Delegate](Documentation/Delegate.md) -1. [Callback](Documentation/Callback.md) -1. [Concurrency](Documentation/Concurrency.md) -1. UIKit - 1. [UITableView](Documentation/UITableView.md) - 1. [UINavigationController](Documentation/UINavigationController.md) -1. [BugFix](Documentation/BugFix.md) + +**■ App を形にする** + +1) [AutoLayout](Documentation/AutoLayout.md) +1) [API](Documentation/API.md) + +**■ 実践練習** + +3) [Error](Documentation/Error.md) +1) [Json](Documentation/Json.md) +1) [Codable](Documentation/Codable.md) + +**■ App の高度な制御** + +6) [Lifecycle](Documentation/VC_Lifecycle.md) +1) [NotificationCenter](Documentation/NotificationCenter.md) +1) [UnitTest](Documentation/UnitTest.md) + +**■ 非同期処理** + +9) [ThreadBlock](Documentation/ThreadBlock.md) +1) [Delegate](Documentation/Delegate.md) +1) [Callback](Documentation/Callback.md) +1) [Concurrency](Documentation/Concurrency.md) + +**■ 定番の UI 表現 (UIKit)** + +13) [UITableView](Documentation/UITableView.md) +1) [UINavigationController](Documentation/UINavigationController.md) + +**■ 実力チェック** + +15) [BugFix](Documentation/BugFix.md) [^git-rebase]: このようなケースで `rebase` コマンドを使うことが必ずしも正しいとは限りません。 どのような方法をとるかはチームで議論するべきと考えます。 ただ、この研修は「`rebase`コマンドを使ってみる」ことも研修の一部としています。 From e5f520660c903fbd216e3418fd4a6fe97d855ccb Mon Sep 17 00:00:00 2001 From: Tomohiro Kumagai Date: Sat, 28 Oct 2023 14:17:36 +0900 Subject: [PATCH 4/5] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 表現を "アプリ" で統一しました。 Co-authored-by: KAWASHIMA Yoshiyuki --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d8375a7..2f03c0d 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ Session1がレビュー待ちの場合... # Session -**■ App を形にする** +**■ アプリを形にする** 1) [AutoLayout](Documentation/AutoLayout.md) 1) [API](Documentation/API.md) @@ -52,7 +52,7 @@ Session1がレビュー待ちの場合... 1) [Json](Documentation/Json.md) 1) [Codable](Documentation/Codable.md) -**■ App の高度な制御** +**■ アプリの高度な制御** 6) [Lifecycle](Documentation/VC_Lifecycle.md) 1) [NotificationCenter](Documentation/NotificationCenter.md) From 4a1e73ba85896bb994514cbc483eed404542b1e8 Mon Sep 17 00:00:00 2001 From: Tomohiro Kumagai Date: Thu, 7 Dec 2023 17:49:39 +0900 Subject: [PATCH 5/5] =?UTF-8?q?=E8=AA=B2=E9=A1=8C=E3=81=AE=E8=AA=AC?= =?UTF-8?q?=E6=98=8E=E6=96=87=E3=82=92=E7=B0=A1=E6=BD=94=E3=81=AB=E3=81=97?= =?UTF-8?q?=E3=81=BE=E3=81=97=E3=81=9F=E3=80=82?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: KAWASHIMA Yoshiyuki --- Documentation/Delegate.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/Delegate.md b/Documentation/Delegate.md index e6b8e5e..7c9fda1 100644 --- a/Documentation/Delegate.md +++ b/Documentation/Delegate.md @@ -14,7 +14,7 @@ UITableViewDelegateはProtocolで、Cellが選択されたときの関数が宣 UITableViewはUITableViewDelegateの実装クラスを保持し、必要な時にDelegateの関数を呼び出します。 ## 課題 -- Delegateパターンを使い、同期APIから天気予報を受け取る +- Delegateパターンを使い、APIの結果を受け取る - ViewControllerに`deinit`を実装し、ログを出力するようにしておく - ViewControllerを閉じた時に`deinit`が呼ばれることを確認する