Add Tree to store all tree files in memory #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation has a performance problem because it always get all files when the passed `query` changes. This significantly increases I/O. I want to avoid the call of I/O by storing all files in memory. This development decision might affect the memory usage, but I want to first try it. This patch just adds `Tree` for the purpose of storing all possible files, which is not yet used by other modules.
yykamei
added a commit
that referenced
this pull request
Aug 27, 2024
In the previous pull request below, `Tree` has been introduced in this repository to store the all files under the `starting_point`. #1059 This patch uses `Tree` in `Screen` and `Candidates` to reduce I/O of getting files.
yykamei
added a commit
that referenced
this pull request
Aug 27, 2024
In the previous pull request below, `Tree` has been introduced in this repository to store the all files under the `starting_point`. #1059 This patch uses `Tree` in `Screen` and `Candidates` to reduce I/O of getting files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a performance problem because it always get all files when the passed
querychanges. This significantly increases I/O. I want to avoid the call of I/O by storing all files in memory. This development decision might affect the memory usage, but I want to first try it.This patch just adds
Treefor the purpose of storing all possible files, which is not yet used by other modules.