Check if getScts exists and is a function #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: TypeError: message.getScts is not a function trace: /lib/functions/modem.js line 1589 solution: check first if "getScts" exist on the message obj and must be type function
Apollon77
suggested changes
Apr 13, 2022
| @@ -163,7 +163,7 @@ module.exports = function(SerialPort) { | |||
| resultData.data = self.arrangeMessages(resultData.data) | |||
| modem.emit('onNewMessageIndicator', resultData) | |||
| modem.emit('onNewMessage', resultData.data[resultData.data.length - 1]) | |||
| if (modem.autoDeleteOnReceive) { | |||
| if (modem.autoDeleteOnReceive && typeof message != 'undefined' ) { | |||
There was a problem hiding this comment.
Suggested change
| if (modem.autoDeleteOnReceive && typeof message != 'undefined' ) { | |
| if (modem.autoDeleteOnReceive && typeof message !== 'undefined' ) { |
There was a problem hiding this comment.
äääähhmm .... where does "message" come from? or am I blind? There is no message initialized in this block ... ?!?
|
Honestly ... I'm nit that sure because the interesting topic would be to understand WHY it is no function ... and in the other case WHY message is undefined zto make sure it is not a "flow" topic |
|
Can you please provide a logging or more details in whcih cases these issues happened ? |
|
@mejuliver Plese check if the issue still occurs in 4.0.1 |
|
@zabsalahid I would close this PR because no reaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: TypeError: message.getScts is not a function
trace: /lib/functions/modem.js line 1589
solution: check first if "getScts" exist on the message obj and must be type function