Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suspected race condition in prompt handling #105

Merged
merged 1 commit into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. Fix race condition in prompt handling

    The current approach to handling prompts involves calling for a prompt
    and then registering a signal handler for a response that indicates the
    prompt had completed. In most cases, if the user were to take action,
    this would be quite slow. However, in the case of automatic responses to
    the prompt, the signal response may appear before the signal handler is
    configured, resulting in blocking forever.
    
    This commit moves the call for a prompt after the signal handling has
    been configured, closing the race window.
    
    Signed-off-by: William Martin <williammartin@github.com>
    williammartin committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    70fd443 View commit details
    Browse the repository at this point in the history