update dependencies; migrate shellescape package to new import path #113
Conversation
Signed-off-by: Piet de Vries <piet@devries.tech>
|
👍 |
|
👍 |
Could you explain the benefits and tradeoffs involved with source Go modules from GitHub Pages? I understand alessio/shellescape#26 changed this, however my knee jerk is holding off upgrading |
|
I think this is best raised to the upstream as we have no influence how the upstream module is defined. My understanding is that without this change we block updating |
|
@mikkeloscar you can also inline the code. The repository is about 3 functions in total so a little dependency is worse than a little copy. |
Are you saying that newer releases of As far as I know, ☝️ should have continued to work irregardless of what the My concernsIf you look at the source of https://al.essio.dev/, it appears this is the <html>
<body>
<script>
(async () => {
const response = await fetch('https://api.github.com/repos/alessio/alessio.github.io/contents/');
const data = await response.json();
let htmlString = '<ul>';
for (let file of data) {
htmlString += `<li><a href="${file.path}">${file.name}</a></li>`;
}
htmlString += '</ul>';
document.getElementsByTagName('body')[0].innerHTML = htmlString;
})()
</script>
<body>
</html>Again, this doesn't objectively add anything and raises questions about exactly what is sourced. |
|
What I mean is you get this error: diff --git a/go.mod b/go.mod
index 8731939..a58030e 100644
--- a/go.mod
+++ b/go.mod
@@ -3,7 +3,7 @@ module github.com/zalando/go-keyring
go 1.18
require (
- al.essio.dev/pkg/shellescape v1.5.1
+ github.com/alessio/shellescape v1.5.1
github.com/danieljoos/wincred v1.2.2
github.com/godbus/dbus/v5 v5.1.0
)
I don't disagree, but unless there is a practical way to work around it we can't without discussing these points with upstream (or inline the functions as @szuecs suggested). |
|
I created #117 for inlining this. I think it's a good idea, but I also don't think it's the end of the world if we don't. I just thought that since we cared a bit in |
A little while back the import path of github.com/alessio/shellescape changed to al.essio.dev/pkg/shellescape . This PR handles that, so people can update again.