Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filters: update godoc for deprecated FilterContext OpenTracing fields #3052

Merged
merged 1 commit into from
Apr 29, 2024
Merged

filters: update godoc for deprecated FilterContext OpenTracing fields #3052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions filters/filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ type FilterContext interface {
// Allow filters to add Tags, Baggage to the trace or set the ComponentName.
//
// Deprecated: OpenTracing is deprecated, see https://github.com/zalando/skipper/issues/2104.
// Use opentracing.SpanFromContext(ctx.Request().Context()).Tracer() to get the proxy span Tracer.
// Use opentracing.SpanFromContext(ctx.Request().Context()).Tracer() to get the Tracer.
Tracer() opentracing.Tracer

// Allow filters to create their own spans
//
// Deprecated: OpenTracing is deprecated, see https://github.com/zalando/skipper/issues/2104.
// Filter spans should be children of the proxy span,
// use opentracing.SpanFromContext(ctx.Request().Context()) to get the proxy span.
// Filter spans should be children of the request span,
// use opentracing.SpanFromContext(ctx.Request().Context()) to get it.
ParentSpan() opentracing.Span

// Returns a clone of the FilterContext including a brand new request object.
Expand Down
Loading