Skip to content

Commit

Permalink
chore: move collection of flaky tests out of pytest_no_flaky
Browse files Browse the repository at this point in the history
  • Loading branch information
RomanBredehoft committed Aug 4, 2023
1 parent 0cf1174 commit a01bc16
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -250,16 +250,22 @@ pytest_macOS_for_GitHub:
--randomly-dont-reset-seed \
${PYTEST_OPTIONS}

# Warning: collecting tests can trigger the paramete search flaky test
# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/3812
.PHONY: check_currentl_flaky_tests # Print the current list of known flaky tests
check_current_flaky_tests:
echo "Skip the following known flaky tests (test file: number of skipped configs):"
poetry run pytest ./tests --collect-only -m flaky -qq

# --ignore makes pytest ignore complete files (because all tests are flaky). This needs to be done
# even though the associated module are marked as "flaky" because this does not seem to work in
# some cases
# even though the associated module are marked as "flaky" because collecting the test is enough to
# trigger the error
# Remove the ignore and include 'check_current_flaky_tests' once the flaky is fixed
# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/3812
.PHONY: pytest_no_flaky # Run pytest but ignore known flaky issues (so no coverage as well)
pytest_no_flaky:
poetry run pytest --version
echo "Skip the following known flaky tests (test file: number of skipped configs):"
poetry run pytest ./tests --collect-only -m flaky -qq
echo "Warning: coverage is disabled"
echo "Warning: known flaky tests are skipped and coverage is disabled"
poetry run pytest tests/ \
--durations=10 -svv \
--capture=tee-sys \
Expand Down

0 comments on commit a01bc16

Please sign in to comment.