Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sim error rate #1002

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix/sim error rate #1002

merged 2 commits into from
Aug 19, 2024

Conversation

rudy-6-4
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2024
@rudy-6-4 rudy-6-4 force-pushed the fix/sim-error-rate branch from 90fa147 to d44d108 Compare August 16, 2024 11:49
@rudy-6-4 rudy-6-4 force-pushed the fix/sim-error-rate branch from d44d108 to ce157e1 Compare August 16, 2024 11:51
@rudy-6-4
Copy link
Contributor Author

The generator using std instead of variance:
https://github.com/zama-ai/tfhe-rs/blob/3397aa81d245152399f05575760a89d2b11db840/tfhe/src/core_crypto/commons/math/random/generator.rs#L648

@rudy-6-4
Copy link
Contributor Author

https://github.com/zama-ai/concrete-internal/issues/786

@rudy-6-4 rudy-6-4 merged commit b6f6d41 into main Aug 19, 2024
33 of 39 checks passed
@rudy-6-4 rudy-6-4 deleted the fix/sim-error-rate branch August 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudy-6-4 @BourgerieQuentin