Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc edits: debugging #1015

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Doc edits: debugging #1015

merged 1 commit into from
Aug 28, 2024

Conversation

yuxizama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 26, 2024
bcm-at-zama
bcm-at-zama requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor suggestions

docs/execution-analysis/debug.md Outdated Show resolved Hide resolved
docs/execution-analysis/debug.md Outdated Show resolved Hide resolved
docs/execution-analysis/debug.md Outdated Show resolved Hide resolved
BourgerieQuentin
BourgerieQuentin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, else looks good.

docs/execution-analysis/debug.md Outdated Show resolved Hide resolved
docs/execution-analysis/debug.md Outdated Show resolved Hide resolved
@bcm-at-zama
Copy link
Contributor

Rebase and squash

bcm-at-zama
bcm-at-zama approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tx

@bcm-at-zama bcm-at-zama merged commit 3a9c2a1 into main Aug 28, 2024
25 of 27 checks passed
@bcm-at-zama bcm-at-zama deleted the Q3doc-review-5 branch August 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcm-at-zama bcm-at-zama bcm-at-zama approved these changes

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuxizama @bcm-at-zama @BourgerieQuentin