-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(frontends): enable simultaneous execution and simulation in mod… #1016
Conversation
30b4291
to
fbcc83b
Compare
fbcc83b
to
4c06d87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What the purpose of the Box stuff? Else look good to me, maybe we should refactor the circuit.py using the Lazy stuff.
Edit: Turns out this is not needed as objects are passed by reference. |
4c06d87
to
323379f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is okay, but it definitely needs tests.
- Start with both disabled, enable both later
- Start with just simulation, enable execution later
- Start with just execution, enable simulation later
- Start with both simulation and execution
323379f
to
51f5480
Compare
Done. |
bf44209
to
7389ed2
Compare
self._initialized = True | ||
|
||
@property | ||
def val(self) -> T: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, but using value
would be better IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to merge.
62eafb1
to
af08e90
Compare
af08e90
to
52f98fe
Compare
…ules